Skip to content

Various clean-up patches for GEM VRAM

Thomas Zimmermann dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm: Replace drm_gem_vram_push_to_system() with kunmap + unpindrivers/gpu/drm/ast/ast_mode.c drivers/gpu/drm/drm_gem_vram_helper.c drivers/gpu/drm/drm_vram_helper_common.c +2 more+20 -620 replies
2/3drm: Rename reserve/unreserve to lock/unlock in GEM VRAM helpersdrivers/gpu/drm/ast/ast_fb.c drivers/gpu/drm/ast/ast_mode.c drivers/gpu/drm/drm_gem_vram_helper.c +3 more+56 -580 replies
3/3drm: Assert that BO is locked in drm_gem_vram_{pin, unpin}_locked()drivers/gpu/drm/drm_gem_vram_helper.c+4 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDaniel Vetter
SeriesA-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] Various clean-up patches for GEM VRAM

Replacing drm_gem_vram_push_to_system() moves policy from drivers back to the memory manager. Now, unused BOs are only evicted when the space is required.

The lock/unlock-renaming patch aligns the interface with other names in DRM. No functional changes are done.

Finally, there's now a lockdep assert that ensures we don't call the GEM VRAM _locked() functions with an unlocked BO.

Patches are against a recent drm-tip and tested on mgag200 and ast HW.

Thomas Zimmermann (3):
drm: Replace drm_gem_vram_push_to_system() with kunmap + unpin
drm: Rename reserve/unreserve to lock/unlock in GEM VRAM helpers
drm: Assert that BO is locked in drm_gem_vram_{pin,unpin}_locked()

 drivers/gpu/drm/ast/ast_fb.c             | 11 ++-
 drivers/gpu/drm/ast/ast_mode.c           | 26 ++++---
 drivers/gpu/drm/drm_gem_vram_helper.c    | 86 ++++++------------------
 drivers/gpu/drm/drm_vram_helper_common.c |  2 -
 drivers/gpu/drm/mgag200/mgag200_cursor.c | 40 +++++------
 drivers/gpu/drm/mgag200/mgag200_fb.c     | 11 ++-
 drivers/gpu/drm/mgag200/mgag200_mode.c   | 15 +++--
 include/drm/drm_gem_vram_helper.h        |  9 ++-
 8 files changed, 80 insertions(+), 120 deletions(-)

--
2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel