Improvement for the DWC3 USB generic driver and fixes for the K2 platforms
Get series with b4
b4 am 20190521142134.5a77d71c@jawaVersions newest first
- v2 Latest0 of 18 patches 0 repliesNew
Patches in v2 No applies recorded yet
None of the 18 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [U-Boot] [PATCH v2 00/18] Improvement for the DWC3 USB generic driver and fixes for the K2 platforms
Quoted 6 lines · On Tue, 21 May 2019 11:36:57 +0000 Siva Durga Prasad Paladugu…
Hi,
Tested the series with one out of tree patch(https://marc.info/?l=u-boot&m=155409909828219 ) on Xilinx ZynqMP and it looks fine. We may need to finalize on
https://marc.info/?l=u-boot&m=155409909828219 as well.
Could you also provide proper Tested-by tag to this patch set? In that way it would automatically be added to patchwork, and your tag would be applied to the patches.
Thanks in advance.
Quoted 164 lines
U-Boot 2019.04-rc4-00065-g5063fa3-dirty (May 21 2019 - 16:58:34 +0530)
Model: ZynqMP ZCU102 Rev1.0 Board: Xilinx ZynqMP DRAM: 4 GiB EL Level: EL2 Chip ID: zu9eg MMC: mmc at ff170000: 0Loading Environment from FAT... *** Warning - bad CRC, using default environment
In: serial at ff000000 Out: serial at ff000000 Err: serial at ff000000 Bootmode: JTAG_MODE Reset reason: EXTERNAL Net: ZYNQ GEM: ff0e0000, phyaddr c, interface rgmii-idWarning: ethernet at
ff0e0000(eth0) using random MAC address - 32:98:cb:f1:92:33 eth0: ethernet atff0e0000
Hit any key to stop autoboot: 0
ZynqMP> usb start
starting USB...
USB0: Register 2000440 NbrPorts 2
Starting the controller
USB XHCI 1.00
scanning bus 0 for devices... 2 USB Device(s) found
scanning usb for storage devices... 1 Storage Device(s) found
ZynqMP> ls usb 0
5242880 dummy.bin
133849600 Image2 file(s), 0 dir(s)
ZynqMP> load usb 0 100000 Image
133849600 bytes read in 1056 ms (120.9 MiB/s)
ZynqMP>Thanks,
Siva-----Original Message-----
From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Jean-Jacques Hiblot Sent: Monday, May 13, 2019 8:00 PM
To: lukma at denx.de; marex at denx.de
Cc: Marcel Ziswiler <[email protected]>;
u-boot at lists.denx.de; Miquel Raynal <[email protected]>; Stefan Roese <[email protected]>; Tom Rini <[email protected]>; Ryder Lee <[email protected]>; Heinrich Schuchardt <[email protected]>; Michal Simek <[email protected]>; Krzysztof Kozlowski <[email protected]>; Maxime Ripard <[email protected]>; Sven Schwermer <[email protected]>; Ramon Fried <[email protected]>; Eugeniu Rosca <[email protected]>; Vitaly Andrianov <[email protected]>; Joe Hershberger <[email protected]>; Tom Warren <[email protected]> Subject:
[U-Boot] [PATCH v2 00/18] Improvement for the DWC3 USB generic driver and fixes for the K2 platformsThe K2 platforms have shown boot issues after switching to the DWC3 generic driver. Those are due to the fact that the USB domains are not turned off before booting linux and the phy were not properly initialized. Fixing it by improving the DWC3-generic driver and handling the USB power domain in the PHY driver. At the same time this series introduce a new uclass (
UCLASS_NOP) to replace usage ofUCLASS_MISCin the USB wrapper because the MISC class now automatically binds all the child devices.Improvements to the DWC3 generic driver are:
- Fix it by switching toUCLASS_NOP
- core: read quirks properties from DT and apply the fixes.
- add a new host driver that uses the DWC3 core (more generic than xhci-dwc3). This should enable most platforms to drop their own
version of the xhci-driver to use the generic one instead.This series also removes the now unused xhci-zynqmp driver and tries to better manage the
Kconfigoptions related to DWC3 gadget/host mode selection.This has been tested with K2 and DRA7 platforms (host and device modes). Travis build:
https://travis-ci.org/jjhiblot/u-boot/builds/515282720Changes in v2:
- Add a test for the NOP uclass
- Update commit logs
- SelectUSB_GADGET_DUALSPEEDifUSB_DWC3_GADGETis selectedJean-Jacques Hiblot (18):
usb: dwc3-generic: removedm_scan_fdt_dev()from theremove()
callback usb: host: remove the xhci-zynqmp driver
dm: Add a No-op uclass
usb: dwc3: UseUCLASS_NOPinstead ofUCLASS_MISCfor the DWC3
generic glue
usb: dwc3: switch to peripheral mode when exiting
usb: xhci: movexhci.hto include usb
usb: dwc3: always use the inlined version of
dwc3_host_init/dwc3_host_exit
usb: dwc3-generic: use platdata
usb: dwc3-generic: factorize code
usb: dwc3-generic: add a new host driver that uses the dwc3 core
usb: dwc3-generic: if no max speed is specified in DT, assume super
speed
usb: dwc3: Adddwc3_of_parse()to get quirks information from DT
usb: dwc3:Kconfig: get rid of obsolete mode selection
ARM: keystone: increase PSC timeout
ARM: keystone: Do not enable the USB power domains at the board
level phy: keystone-usb: handle the transition of the USB power domain
configs:k2g_evm_defconfig: disableXHCI_DWC3and enable
KEYSTONE_USB_PHY
ARM: DTS: keystone: complete the description of the USB PHY devicesMAINTAINERS | 1 + arch/arm/dts/keystone-k2e-evm-u-boot.dtsi | 32 ++++ arch/arm/dts/keystone-k2g-evm-u-boot.dtsi | 28 ++++ arch/arm/dts/keystone-k2hk-evm-u-boot.dtsi | 14 ++ arch/arm/dts/keystone-k2l-evm-u-boot.dtsi | 18 +++ .../arm/mach-keystone/include/mach/psc_defs.h | 2 +- arch/sandbox/dts/test.dts | 12 ++ board/ti/ks2_evm/board.c | 13 -- configs/avnet_ultra96_rev1_defconfig | 1 - configs/evb-rk3328_defconfig | 1 + configs/k2g_evm_defconfig | 3 +- .../xilinx_zynqmp_zc1751_xm015_dc1_defconfig | 1 - .../xilinx_zynqmp_zc1751_xm016_dc2_defconfig | 1 - .../xilinx_zynqmp_zc1751_xm017_dc3_defconfig | 1 - configs/xilinx_zynqmp_zcu100_revC_defconfig | 1 - configs/xilinx_zynqmp_zcu102_rev1_0_defconfig | 1 - configs/xilinx_zynqmp_zcu102_revA_defconfig | 1 - configs/xilinx_zynqmp_zcu102_revB_defconfig | 1 - configs/xilinx_zynqmp_zcu104_revA_defconfig | 1 - configs/xilinx_zynqmp_zcu104_revC_defconfig | 1 - configs/xilinx_zynqmp_zcu106_revA_defconfig | 1 - configs/xilinx_zynqmp_zcu111_revA_defconfig | 1 - drivers/core/uclass.c | 5 + drivers/phy/keystone-usb-phy.c | 22 +++ drivers/usb/dwc3/Kconfig | 18 +-- drivers/usb/dwc3/core.c | 84 +++++++++- drivers/usb/dwc3/core.h | 6 +- drivers/usb/dwc3/dwc3-generic.c | 150 ++++++++++++++---- drivers/usb/host/Kconfig | 7 - drivers/usb/host/Makefile | 1 - drivers/usb/host/xhci-dwc3.c | 2 +- drivers/usb/host/xhci-exynos5.c | 2 +- drivers/usb/host/xhci-fsl.c | 2 +- drivers/usb/host/xhci-mem.c | 2 +- drivers/usb/host/xhci-mvebu.c | 2 +- drivers/usb/host/xhci-omap.c | 2 +- drivers/usb/host/xhci-pci.c | 2 +- drivers/usb/host/xhci-rcar.c | 2 +- drivers/usb/host/xhci-ring.c | 2 +- drivers/usb/host/xhci-rockchip.c | 2 +- drivers/usb/host/xhci-zynqmp.c | 146 ----------------- drivers/usb/host/xhci.c | 2 +- drivers/usb/phy/omap_usb_phy.c | 2 +- include/dm/uclass-id.h | 1 + {drivers/usb/host => include/usb}/xhci.h | 0 test/dm/Makefile | 1 + test/dm/nop.c | 73 +++++++++ 47 files changed, 421 insertions(+), 253 deletions(-) create mode100644
arch/arm/dts/keystone-k2l-evm-u-boot.dtsidelete mode 100644drivers/usb/host/xhci-zynqmp.crename {drivers/usb/host=>include/usb}/xhci.h(100%) create mode 100644test/dm/nop.c
Quoted 7 lines
--
2.17.1_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190521/e89fa8f7/attachment.sig>