Skip to content

efi_loader: implement deprecated Unicode collation protocol

AKASHI Takahiro u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/2] efi_loader: implement deprecated Unicode collation protocol
Quoted 14 lines · Heinrich Schuchardt
Quoted 13 lines · AKASHI Takahiro

Heinrich,

Quoted 6 lines · Heinrich Schuchardt

In EFI 1.10 a version of the Unicode collation protocol using ISO 639-2 language codes existed. This protocol is not part of the UEFI specification any longer. Unfortunately it is required to run the UEFI Self Certification Test (SCT) II, version 2.6, 2017. So we implement it here for the sole purpose of running the SCT. It can be removed once a compliant SCT is available.

I remember that Alex always rejected this kind of patch, saying that an upstream (SCT in this case) should be fixed in the first place.

Quoted 8 lines
Quoted 2 lines

Do you want to change this policy?
(I'm just asking.)

I am using SCT a lot to test my patches. I want to be able to run the tests on the final code.

I have raised a ticket for upstream SCT but did not see any reaction up to now.

but less than two weeks have passed. Why not ping again?

Quoted 4 lines

Making this deprecated protocol a config option deselected by default is the most plausible solution to me. In the Kconfig comment I made it clear that this protocol is going to be removed when the SCT has been corrected.

It is likely that your patch will be reverted soon in 2019.09.
(I don't know release cycle of UEFI SCT though.)
I believe that such a patch should be maintained only in your local repository.

-Takahiro Akashi

Quoted 27 lines

Best regards

Heinrich

Quoted 22 lines

-Takahiro Akashi

Quoted 18 lines

The configuration option defaults to no.

Heinrich Schuchardt (2):
efi_loader: rename Unicode collation protocol 2 variables
efi_loader: implement deprecated Unicode collation protocol

 include/efi_api.h                      |  5 ++++
 include/efi_loader.h                   |  9 +++++--
 lib/efi_loader/Kconfig                 | 15 ++++++++++--
 lib/efi_loader/Makefile                |  2 +-
 lib/efi_loader/efi_root_node.c         |  7 +++++-
 lib/efi_loader/efi_unicode_collation.c | 33 +++++++++++++++++++++++---
 lib/efi_selftest/Makefile              |  3 ++-
 7 files changed, 64 insertions(+), 10 deletions(-)

--
2.20.1