Skip to content

nvme: Improve processing paused support

Keith Busch linux-nvme 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3nvme-pci: reset timeout when processing is pauseddrivers/nvme/host/pci.c+1 -12 replies
2/3nvme: rearm fw notification in admin only statedrivers/nvme/host/core.c+2 -11 reply
3/3nvme: quiesce admin queue for fw activationdrivers/nvme/host/core.c+6 -03 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] nvme: Improve processing paused support

From: Keith Busch <[email protected]>

Improve firmware activation over what we're currently doing. The main thing is that we do not want to esacalate recovery while the current status has CSTS.PP set as the recovery attempt may interfere with a critical controller operation.

There still exists a race where the controller may clear CSTS Processing Paused at the same time a stalled request times out. We would normally want to reset the timer for that, but this is at least a state that can handle error recovery without interrupting background operations, so the only harm caused from encountering this unlikely event is a longer latency back to ready.

My previous patch to address this used help from the block layer, but had some issues. This series only involves the nvme driver and just addresses the main concern without addressing the corner cases.

Keith Busch (3):
nvme-pci: reset timeout when processing is paused
nvme: rearm fw notification in admin only state
nvme: quiesce admin queue for fw activation

 drivers/nvme/host/core.c | 9 ++++++++-
 drivers/nvme/host/pci.c  | 2 +-
 2 files changed, 9 insertions(+), 2 deletions(-)
Signature · 1 line
2.14.4