Skip to content

fstests: copy_file_range() tests

Amir Goldstein fstests linux-xfs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 1 replyIn review
  2. v36 patches 12 repliesSuperseded
  3. v25 patches 3 repliesSuperseded

Changes in v4 from the cover letter

- swapfile and immutable file tests already merged (generic/55[34])
- Use an actual loopdev owned by this test
- Use /dev/null and /dev/zero and char devices for test
- _notrun if cross-device copy_range return EXDEV

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3common/rc: check support for xfs_io copy_range -f Ncommon/rc+8 -10 replies
2/3generic: copy_file_range bounds testtests/generic/990 tests/generic/990.out tests/generic/group+172 -01 reply
3/3generic: cross-device copy_file_range testtests/generic/991 tests/generic/991.out tests/generic/group+69 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/3] fstests: copy_file_range() tests

Eryu,

These are the two remaining copy_file_range() tests which I used to verify the kernel fixes that are now in master [1].

The bounds check test depends on an xfs_io change that was merged to xfsprogs v5.1.0-rc1 (copy_range -f).

The cross-device copy test checks a new functionality, so it does _notrun if copy_range return EXDEV instead of failing.

Thanks,
Amir.

[1] https://lore.kernel.org/linux-fsdevel/20190709163947.GE5164@magnolia/

Changes from v3:
- swapfile and immutable file tests already merged (generic/55[34])
- Use an actual loopdev owned by this test
- Use /dev/null and /dev/zero and char devices for test
- _notrun if cross-device copy_range return EXDEV

Changes from v2:
- Change blockdev in test to loop and _require_loop (Olga)
- Implement and use _require_xfs_io_command copy_range -f

Changes from v1:
- Remove patch to test EINVAL behavior instead of short copy
- Remove 'chmod -r' permission drop test case
- Split out test for swap/immutable file copy
- Split of cross-device copy test

Amir Goldstein (3):
common/rc: check support for xfs_io copy_range -f N
generic: copy_file_range bounds test
generic: cross-device copy_file_range test

 common/rc             |   9 ++-
 tests/generic/990     | 134 ++++++++++++++++++++++++++++++++++++++++++
 tests/generic/990.out |  37 ++++++++++++
 tests/generic/991     |  64 ++++++++++++++++++++
 tests/generic/991.out |   4 ++
 tests/generic/group   |   2 +
 6 files changed, 249 insertions(+), 1 deletion(-)
 create mode 100755 tests/generic/990
 create mode 100644 tests/generic/990.out
 create mode 100755 tests/generic/991
 create mode 100644 tests/generic/991.out
Signature · 1 line
2.17.1