Skip to content

mtd: cfi_cmdset_0002: Fix flash write issue for OpenWrt Project

Tokunori Ikegami linux-mtd stable 3 versions – Applied

Status from this message: Merged into git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest9 patches 6 repliesApplied
  2. v79 patches 3 repliesSuperseded
  3. v611 patches 5 repliesSuperseded

Patches in v8 Applied

#Subject and filesSizeRepliesApplied
1/9mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword()drivers/mtd/chips/cfi_cmdset_0002.c+12 -75 replies
2/9mtd: cfi_cmdset_0002: Remove goto statement from do_write_buffer()drivers/mtd/chips/cfi_cmdset_0002.c+27 -270 replies
3/9mtd: cfi_cmdset_0002: Split do_write_oneword() to reduce function sizedrivers/mtd/chips/cfi_cmdset_0002.c+50 -400 replies
4/9mtd: cfi_cmdset_0002: Split do_write_oneword() op_done goto statementdrivers/mtd/chips/cfi_cmdset_0002.c+40 -170 replies
5/9mtd: cfi_cmdset_0002: Remove op_done goto statement from do_write_oneword()drivers/mtd/chips/cfi_cmdset_0002.c+3 -20 replies
6/9mtd: cfi_cmdset_0002: Split write-to-buffer-reset sequencedrivers/mtd/chips/cfi_cmdset_0002.c+22 -160 replies
7/9mtd: cfi_cmdset_0002: Split to wait write buffer to check if completeddrivers/mtd/chips/cfi_cmdset_0002.c+50 -390 replies
8/9mtd: cfi_cmdset_0002: Split do_write_oneword() to reduce exit pathsdrivers/mtd/chips/cfi_cmdset_0002.c+24 -140 replies
9/9mtd: cfi_cmdset_0002: Disable write buffer functions if FORCE_WORD_WRITE is 1drivers/mtd/chips/cfi_cmdset_0002.c+6 -00 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchChris Packham
1/9
2/9
3/9R-b
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/9] mtd: cfi_cmdset_0002: Fix flash write issue for OpenWrt Project

The change is based on the fix for flash erase to use chip_good() done in the past. And it is fixed as same way in the OpenWrt Project as below.
<https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=ddc11c3932>
Also includes some refactoring changes.

Co: Hauke Mehrtens <[email protected]>
Cc: Chris Packham <[email protected]>
Cc: Joakim Tjernlund <[email protected]>
Cc: [email protected]

Tokunori Ikegami (9):
mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword()
mtd: cfi_cmdset_0002: Remove goto statement from do_write_buffer()
mtd: cfi_cmdset_0002: Split do_write_oneword() to reduce function size
mtd: cfi_cmdset_0002: Split do_write_oneword() op_done goto statement
mtd: cfi_cmdset_0002: Remove op_done goto statement from
do_write_oneword()
mtd: cfi_cmdset_0002: Split write-to-buffer-reset sequence
mtd: cfi_cmdset_0002: Split to wait write buffer to check if completed
mtd: cfi_cmdset_0002: Split do_write_oneword() to reduce exit paths
mtd: cfi_cmdset_0002: Disable write buffer functions if
FORCE_WORD_WRITE is 1

 drivers/mtd/chips/cfi_cmdset_0002.c | 296 ++++++++++++++++++++++--------------
 1 file changed, 184 insertions(+), 112 deletions(-)
Signature · 6 lines
2.11.0


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/