Skip to content

Makefile: Generalize recursion machinery

Markus Armbruster qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Makefile: Remove code to smooth transition to config.statusMakefile+1 -80 replies
2/4Makefile: Drop bogus cleaning of $(ALL_SUBDIRS)/qemu-options.defMakefile+0 -10 replies
3/4Makefile: Rename targets for make recursionMakefile configure tests/Makefile.include+24 -172 replies
4/4Makefile: Reuse all's recursion machinery for clean and installMakefile+25 -281 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonPhilippe Mathieu-Daudé
1/4R-b R-b T-b
2/4R-b R-b T-b
3/4R-b R-b T-b R-b T-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/4] Makefile: Generalize recursion machinery

We make a few sub-directories recursively, in particular $(TARGET_DIRS).

For goal "all", we do it the nice way: "all" has a prerequisite subdir-T for each T in $(TARGET_DIRS), and T's recipe runs make recursively. Behaves nicely with -j and -k.

For other goals such as "clean" and "install", the recipe runs make recursively in a for loop. Ignores -j and -k.

Generalize the recursion machinery used by "all" so we can reuse it for "clean" and "install".

This was previously posted as PATCH 1-4 of "[RFC v4 0/7] Baby steps towards saner headers". Changes since then:
* PATCH 1: Don't lose @ [Philippe]
* PATCH 3: Update check-report-qtest-%.tap [Philippe]

Markus Armbruster (4):
Makefile: Remove code to smooth transition to config.status
Makefile: Drop bogus cleaning of $(ALL_SUBDIRS)/qemu-options.def
Makefile: Rename targets for make recursion
Makefile: Reuse all's recursion machinery for clean and install

 Makefile               | 73 ++++++++++++++++++++----------------------
 configure              |  6 ++--
 tests/Makefile.include |  5 +--
 3 files changed, 40 insertions(+), 44 deletions(-)
Signature · 1 line
2.17.2