Skip to content

request-pull: warn if the remote object is not the same as the local one

Paolo Bonzini git 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2request-pull: quote regex metacharacters in local refgit-request-pull.sh t/t5150-request-pull.sh+20 -30 replies
2/2request-pull: warn if the remote object is not the same as the local onegit-request-pull.sh t/t5150-request-pull.sh+63 -150 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] request-pull: warn if the remote object is not the same as the local one

From: Paolo Bonzini <[email protected]>

In some cases, git request-pull might be invoked with remote and local objects that differ even though they point to the same commit. For example, the remote object might be a lightweight tag vs. an annotated tag on the local side, or the user might have reworded the tag locally and forgotten to push it.

When this happens git-request-pull will not warn, because it only checks that "git ls-remote" returns an SHA1 that matches the local commit. Patch 2 of this series makes git-request-pull remember the tag object's SHA1 while processing the "git ls-remote" output, so that it can be matched against the local object.

Paolo Bonzini (2):
request-pull: quote metacharacters in local ref
request-pull: warn if the remote object is not the same as the local one

 git-request-pull.sh     | 46 ++++++++++++++++++++++-------------
 t/t5150-request-pull.sh | 53 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 82 insertions(+), 17 deletions(-)
Signature · 1 line
2.21.0