Skip to content

qom: Use BUS()/DEVICE() macros instead of looking inside definitions

Philippe Mathieu-Daudé qemu-devel qemu-trivial 2 versions Applied

Status from this message: Applied to my trivial-patches branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 20 repliesApplied
  2. v11 patch 2 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/10hw/scsi/vmw_pvscsi: Use qbus_reset_all() directlyhw/scsi/vmw_pvscsi.c+2 -22 replies
2/10hw/scsi: Use the QOM BUS() macro to access BusState.qbushw/scsi/lsi53c895a.c hw/scsi/mptsas.c hw/scsi/virtio-scsi.c+4 -42 replies
3/10hw/pci-bridge: Use the QOM BUS() macro to access BusState.qbushw/pci/pci_bridge.c+1 -12 replies
4/10hw/s390x/event-facility: Use the QOM BUS() macro to access BusState.qbushw/s390x/event-facility.c+2 -22 replies
5/10hw/sd: Use the QOM BUS() macro to access BusState.qbushw/sd/milkymist-memcard.c hw/sd/ssi-sd.c+2 -22 replies
6/10hw/audio/ac97: Use the QOM DEVICE() macro to access DeviceState.qdevhw/audio/ac97.c+1 -12 replies
7/10hw/isa: Use the QOM DEVICE() macro to access DeviceState.qdevhw/isa/lpc_ich9.c hw/isa/vt82c686.c+2 -22 replies
8/10hw/usb-storage: Use the QOM DEVICE() macro to access DeviceState.qdevhw/usb/dev-storage.c+1 -12 replies
9/10hw/vfio/pci: Use the QOM DEVICE() macro to access DeviceState.qdevhw/vfio/pci.c+2 -22 replies
10/10hw/watchdog/wdt_i6300esb: Use DEVICE() macro to access DeviceState.qdevhw/watchdog/wdt_i6300esb.c+1 -12 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchPeter MaydellMarcel ApfelbaumCornelia HuckGerd HoffmannDmitry FleytmanAlex WilliamsonLaurent Vivier
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10A-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 00/10] qom: Use BUS()/DEVICE() macros instead of looking inside definitions

v1 was a simple patch:
'use qbus_reset_all() directly instead of qbus_reset_all_fn' where I was looking inside the definition of BusState.

Peter suggested to use the prefered QOM style, using the BUS/DEVICE macros. While here, I also cleaned the rest of the codebase.

Philippe Mathieu-Daudé (10):
hw/scsi/vmw_pvscsi: Use qbus_reset_all() directly
hw/scsi: Use the QOM BUS() macro to access BusState.qbus hw/pci-bridge: Use the QOM BUS() macro to access BusState.qbus hw/s390x/event-facility: Use the QOM BUS() macro to access
BusState.qbus
hw/sd: Use the QOM BUS() macro to access BusState.qbus hw/audio/ac97: Use the QOM DEVICE() macro to access DeviceState.qdev hw/isa: Use the QOM DEVICE() macro to access DeviceState.qdev hw/usb-storage: Use the QOM DEVICE() macro to access DeviceState.qdev hw/vfio/pci: Use the QOM DEVICE() macro to access DeviceState.qdev hw/watchdog/wdt_i6300esb: Use DEVICE() macro to access
DeviceState.qdev

 hw/audio/ac97.c            | 2 +-
 hw/isa/lpc_ich9.c          | 2 +-
 hw/isa/vt82c686.c          | 2 +-
 hw/pci/pci_bridge.c        | 2 +-
 hw/s390x/event-facility.c  | 4 ++--
 hw/scsi/lsi53c895a.c       | 2 +-
 hw/scsi/mptsas.c           | 4 ++--
 hw/scsi/virtio-scsi.c      | 2 +-
 hw/scsi/vmw_pvscsi.c       | 4 ++--
 hw/sd/milkymist-memcard.c  | 2 +-
 hw/sd/ssi-sd.c             | 2 +-
 hw/usb/dev-storage.c       | 2 +-
 hw/vfio/pci.c              | 4 ++--
 hw/watchdog/wdt_i6300esb.c | 2 +-
 14 files changed, 18 insertions(+), 18 deletions(-)
Signature · 1 line
2.20.1