Skip to content

media: vivid: add HDMI (dis)connect emulation

Johan Korsnes linux-media 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 1 replyIn review
  2. v29 patches 3 repliesSuperseded
  3. v18 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- Various checkpatch.pl fixes. There are still some warnings as I am not sure those really apply. Please let me know if they do, and I will fix them ASAP.
- PTR_ERR_OR_ZERO -> PTR_ERR where applicable
- Fix broken check for cec adapter not NULL

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9media: vivid: make input dv_timings per-inputdrivers/media/platform/vivid/vivid-core.c drivers/media/platform/vivid/vivid-core.h drivers/media/platform/vivid/vivid-ctrls.c +3 more+69 -340 replies
2/9media: vivid: make input std_signal per-inputdrivers/media/platform/vivid/vivid-core.c drivers/media/platform/vivid/vivid-core.h drivers/media/platform/vivid/vivid-ctrls.c +4 more+64 -460 replies
3/9media: vivid: add display present controldrivers/media/platform/vivid/vivid-core.c drivers/media/platform/vivid/vivid-core.h drivers/media/platform/vivid/vivid-ctrls.c +1 more+29 -00 replies
4/9media: vivid: add number of HDMI ports to device statedrivers/media/platform/vivid/vivid-core.c drivers/media/platform/vivid/vivid-core.h+4 -00 replies
5/9media: vivid: add HDMI (dis)connect TX emulationdrivers/media/platform/vivid/vivid-core.h drivers/media/platform/vivid/vivid-ctrls.c+27 -10 replies
6/9media: vivid: add HDMI (dis)connect RX emulationdrivers/media/platform/vivid/vivid-core.h drivers/media/platform/vivid/vivid-ctrls.c+23 -20 replies
7/9media: vivid: reorder CEC allocation and control set-updrivers/media/platform/vivid/vivid-core.c+58 -420 replies
8/9media: vivid: add CEC support to display present ctrldrivers/media/platform/vivid/vivid-ctrls.c drivers/media/platform/vivid/vivid-vid-cap.c drivers/media/platform/vivid/vivid-vid-common.c+38 -60 replies
9/9media: vivid.rst: describe display present controlDocumentation/media/v4l-drivers/vivid.rst+5 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/9] media: vivid: add HDMI (dis)connect emulation

This patch series makes vivid V4L2-compliant by adding HDMI (dis)- connect emulation. This is done by by adding a custom display_present control to vivid output HDMI devices, along with the following standard controls:

-ctrl_tx_edid_present
-ctrl_tx_hotplug
-ctrl_tx_rxsense
-ctrl_rx_power_present

With regard to v4l2-compliance:
Series fixes the following 1/1 warning for HDMI input devices:
-V4L2_CID_DV_RX_POWER_PRESENT not found for input n
Series fixes the following 2/2 warnings for HDMI ouptut devices:
-V4L2_CID_DV_TX_HOTPLUG not found for output n -V4L2_CID_DV_TX_EDID_PRESENT not found for output n

Regards,
Johan

v2 -> v3:
- Various checkpatch.pl fixes. There are still some warnings as I am not sure those really apply. Please let me know if they do, and I will fix them ASAP.
- PTR_ERR_OR_ZERO -> PTR_ERR where applicable
- Fix broken check for cec adapter not NULL

v1 -> v2:
- New patch: media: vivid: reorder CEC allocation and control set-up
- vidioc_s_edid: Use bitmask (not boolean) value for bitmask controls
- vidioc_g_edid: Changed dev->output to edid->pad

Johan Korsnes (9):
media: vivid: make input dv_timings per-input
media: vivid: make input std_signal per-input
media: vivid: add display present control
media: vivid: add number of HDMI ports to device state
media: vivid: add HDMI (dis)connect TX emulation
media: vivid: add HDMI (dis)connect RX emulation
media: vivid: reorder CEC allocation and control set-up
media: vivid: add CEC support to display present ctrl
media: vivid.rst: describe display present control

Documentation/media/v4l-drivers/vivid.rst     |   5 +
drivers/media/platform/vivid/vivid-core.c     | 120 ++++++++++------
drivers/media/platform/vivid/vivid-core.h     |  32 +++--
drivers/media/platform/vivid/vivid-ctrls.c    | 108 ++++++++++++--
.../media/platform/vivid/vivid-kthread-cap.c  |   8 +-
drivers/media/platform/vivid/vivid-vbi-cap.c  |  16 +--
drivers/media/platform/vivid/vivid-vid-cap.c  | 135 ++++++++++++------
.../media/platform/vivid/vivid-vid-common.c   |   8 +-
drivers/media/platform/vivid/vivid-vid-out.c  |   6 +
9 files changed, 312 insertions(+), 126 deletions(-)