Skip to content

RFC python: refactor qemu/__init__.py

John Snow qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest3 patches 6 repliesIn review
  2. v1 RFC2 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Retain python 2.7+ compatibility :(
- Refactor shutdown a little more aggressively

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3python/qemu: split QEMUMachine out from underneath __init__.pypython/qemu/__init__.py python/qemu/machine.py python/qemu/qtest.py +7 more+540 -5192 replies
2/3machine.py: minor delintingpython/qemu/machine.py+22 -110 replies
3/3QEMUMachine: Don't suppress stack traces on closepython/qemu/machine.py+23 -180 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-devel] [RFC PATCH v2 0/3] python: refactor qemu/__init__.py

There's a lot of code hiding in what is ostensibly a package configuration file. Let's break that out into something more visible.

V2:
- Retain python 2.7+ compatibility :(
- Refactor shutdown a little more aggressively

John Snow (3):
python/qemu: split QEMUMachine out from underneath __init__.py machine.py: minor delinting
QEMUMachine: Don't suppress stack traces on close

 python/qemu/__init__.py                   | 502 +-------------------
 python/qemu/machine.py                    | 536 ++++++++++++++++++++++
 python/qemu/qtest.py                      |   2 +-
 scripts/device-crash-test                 |   2 +-
 scripts/render_block_graph.py             |   2 +-
 tests/acceptance/avocado_qemu/__init__.py |   2 +-
 tests/acceptance/virtio_version.py        |   2 +-
 tests/migration/guestperf/engine.py       |  22 +-
 tests/qemu-iotests/235                    |   2 +-
 tests/vm/basevm.py                        |   3 +-
 10 files changed, 556 insertions(+), 519 deletions(-)
 create mode 100644 python/qemu/machine.py
Signature · 1 line
2.21.0