Skip to content

Fixes for DSA tagging using 802.1Q

Vladimir Oltean netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: dsa: tag_8021q: Change order of rx_vid setupnet/dsa/tag_8021q.c+15 -40 replies
2/2net: dsa: tag_8021q: Create a stable binary formatnet/dsa/tag_8021q.c+50 -100 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchFlorian Fainelli
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 net 0/2] Fixes for DSA tagging using 802.1Q

During the prototyping for the "Decoupling PHYLINK from struct net_device" patchset, the CPU port of the sja1105 driver was moved to a different spot. This uncovered an issue in the tag_8021q DSA code, which used to work by mistake - the CPU port was the last hardware port numerically, and this was masking an ordering issue which is very likely to be seen in other drivers that make use of 802.1Q tags.

A question was also raised whether the VID numbers bear any meaning, and the conclusion was that they don't, at least not in an absolute sense. The second patch defines bit fields inside the DSA 802.1Q VID so that tcpdump can decode it unambiguously (although the meaning is now clear even by visual inspection).

Ioana Ciornei (1):
net: dsa: tag_8021q: Change order of rx_vid setup

Vladimir Oltean (1):
net: dsa: tag_8021q: Create a stable binary format

 net/dsa/tag_8021q.c | 79 +++++++++++++++++++++++++++++++++++++--------
 1 file changed, 65 insertions(+), 14 deletions(-)
Signature · 1 line
2.17.1