Skip to content

F2FS Checkpointing without GC, related fixes

Daniel Rosenberg linux-doc linux-f2fs-devel linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest4 patches 6 repliesIn review

Changes in v3 from the cover letter

Adjust threshold for initial unusable blocks
Patches to fix underflows
Added option to set a block limit in addition to a percent for initial unusable space

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4f2fs: Lower threshold for disable_cp_againfs/f2fs/segment.c+5 -31 reply
2/4f2fs: Fix root reserved on remountfs/f2fs/super.c+2 -11 reply
3/4f2fs: Fix accounting for unusable blocksfs/f2fs/f2fs.h+10 -53 replies
4/4f2fs: Add option to limit required GC for checkpoint=disableDocumentation/ABI/testing/sysfs-fs-f2fs Documentation/filesystems/f2fs.txt fs/f2fs/f2fs.h +3 more+99 -261 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchChao Yu
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] F2FS Checkpointing without GC, related fixes

The first patch adjusts the default allowable holes for checkpointing, and the next two patches fix underflow issues related to inc_valid_block_count and inc_valid_node_count. The final one adds a new feature for checkpointing where the user can specify an acceptable amount of space to lose access to up front in checkpointing=disable mode instead of requiring garbage collection.

There is still a question around what to do when the current reserved space is less than reserved. As it stands, when a block is deleted, if it was an old block, the space is not actually given back, and is marked as unusable. But current reserve may still rise towards reserve, which would make freeing one block result in a net loss of one block, as opposed to no change. Reserved and unusable serve the same function, so it may make sense to just handle it as max(current_reserved, unusable), which effectively removes the double counting. I'm leaving that until later.

Changes from v2:
Adjust threshold for initial unusable blocks
Patches to fix underflows
Added option to set a block limit in addition to a percent for initial unusable space

Daniel Rosenberg (4):
f2fs: Lower threshold for disable_cp_again
f2fs: Fix root reserved on remount
f2fs: Fix accounting for unusable blocks
f2fs: Add option to limit required GC for checkpoint=disable

 Documentation/ABI/testing/sysfs-fs-f2fs |  8 ++++
 Documentation/filesystems/f2fs.txt      | 19 +++++++-
 fs/f2fs/f2fs.h                          | 22 ++++++---
 fs/f2fs/segment.c                       | 21 +++++++--
 fs/f2fs/super.c                         | 62 ++++++++++++++++---------
 fs/f2fs/sysfs.c                         | 16 +++++++
 6 files changed, 115 insertions(+), 33 deletions(-)
Signature · 1 line
2.22.0.rc1.257.g3120a18244-goog