Skip to content

blk-mq/scsi: convert private reply queue into blk_mq hw queue

Ming Lei linux-block linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 38 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9blk-mq: allow hw queues to share hostwide tagsblock/blk-mq-debugfs.c block/blk-mq-sched.c block/blk-mq-tag.c +3 more+33 -26 replies
2/9block: null_blk: introduce module parameter of 'g_host_tags'drivers/block/null_blk_main.c+6 -04 replies
3/9scsi: Add template flag 'host_tagset'drivers/scsi/scsi_lib.c include/scsi/scsi_host.h+5 -01 reply
4/9scsi_debug: support host tagsetdrivers/scsi/scsi_debug.c+3 -03 replies
5/9scsi: introduce scsi_cmnd_hctx_index()include/scsi/scsi_cmnd.h+15 -01 reply
6/9scsi: hpsa: convert private reply queue to blk-mq hw queuedrivers/scsi/hpsa.c+19 -303 replies
7/9scsi: hisi_sas_v3: convert private reply queue to blk-mq hw queuedrivers/scsi/hisi_sas/hisi_sas.h drivers/scsi/hisi_sas/hisi_sas_main.c drivers/scsi/hisi_sas/hisi_sas_v3_hw.c+36 -488 replies
8/9scsi: megaraid: convert private reply queue to blk-mq hw queuedrivers/scsi/megaraid/megaraid_sas_base.c drivers/scsi/megaraid/megaraid_sas_fusion.c+20 -348 replies
9/9scsi: mp3sas: convert private reply queue to blk-mq hw queuedrivers/scsi/mpt3sas/mpt3sas_base.c drivers/scsi/mpt3sas/mpt3sas_base.h drivers/scsi/mpt3sas/mpt3sas_scsih.c+31 -632 replies

Reviews trailers per patch

8 of 9 patches have a Reviewed-by or Acked-by.

PatchHannes ReineckeMinwoo Im
1/9R-b
2/9R-b R-b
3/9R-b
4/9R-b R-b
5/9R-b
6/9R-b
7/9
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] blk-mq/scsi: convert private reply queue into blk_mq hw queue

Hi,

The 1st patch introduces support hostwide tags for multiple hw queues via the simplest approach to share single 'struct blk_mq_tags' instance among all hw queues. In theory, this way won't cause any performance drop. Even small IOPS improvement can be observed on random IO on null_blk/scsi_debug.

By applying the hostwide tags for MQ, we can convert some SCSI driver's private reply queue into generic blk-mq hw queue, then at least two improvement can be obtained:

1) the private reply queue maping can be removed from drivers, since the mapping has been implemented as generic API in blk-mq core

2) it helps to solve the generic managed IRQ race[1] during CPU hotplug in generic way, otherwise we have to re-invent new way to address the same issue for these drivers using private reply queue.

[1] https://lore.kernel.org/linux-block/[email protected]/T/#m6d95e2218bdd712ffda8f6451a0bb73eb2a651af

Any comment and test feedback are appreciated.

Thanks,
Ming

Hannes Reinecke (1):
scsi: Add template flag 'host_tagset'

Ming Lei (8):
blk-mq: allow hw queues to share hostwide tags
block: null_blk: introduce module parameter of 'g_host_tags'
scsi_debug: support host tagset
scsi: introduce scsi_cmnd_hctx_index()
scsi: hpsa: convert private reply queue to blk-mq hw queue
scsi: hisi_sas_v3: convert private reply queue to blk-mq hw queue
scsi: megaraid: convert private reply queue to blk-mq hw queue
scsi: mp3sas: convert private reply queue to blk-mq hw queue

 block/blk-mq-debugfs.c                      |  1 +
 block/blk-mq-sched.c                        |  8 +++
 block/blk-mq-tag.c                          |  6 ++
 block/blk-mq.c                              | 14 ++++
 block/elevator.c                            |  5 +-
 drivers/block/null_blk_main.c               |  6 ++
 drivers/scsi/hisi_sas/hisi_sas.h            |  2 +-
 drivers/scsi/hisi_sas/hisi_sas_main.c       | 36 +++++-----
 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c      | 46 +++++--------
 drivers/scsi/hpsa.c                         | 49 ++++++--------
 drivers/scsi/megaraid/megaraid_sas_base.c   | 50 +++++---------
 drivers/scsi/megaraid/megaraid_sas_fusion.c |  4 +-
 drivers/scsi/mpt3sas/mpt3sas_base.c         | 74 ++++-----------------
 drivers/scsi/mpt3sas/mpt3sas_base.h         |  3 +-
 drivers/scsi/mpt3sas/mpt3sas_scsih.c        | 17 +++++
 drivers/scsi/scsi_debug.c                   |  3 +
 drivers/scsi/scsi_lib.c                     |  2 +
 include/linux/blk-mq.h                      |  1 +
 include/scsi/scsi_cmnd.h                    | 15 +++++
 include/scsi/scsi_host.h                    |  3 +
 20 files changed, 168 insertions(+), 177 deletions(-)
Signature · 1 line
2.20.1