blk-mq/scsi: convert private reply queue into blk_mq hw queue
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 38 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | blk-mq: allow hw queues to share hostwide tagsblock/ block/ block/ +3 more | +33 | 6 replies | |
| 2/9 | block: null_blk: introduce module parameter of 'g_host_tags'drivers/ | +6 | 4 replies | |
| 3/9 | scsi: Add template flag 'host_tagset'drivers/ include/ | +5 | 1 reply | |
| 4/9 | scsi_debug: support host tagsetdrivers/ | +3 | 3 replies | |
| 5/9 | scsi: introduce scsi_cmnd_hctx_index()include/ | +15 | 1 reply | |
| 6/9 | scsi: hpsa: convert private reply queue to blk-mq hw queuedrivers/ | +19 | 3 replies | |
| 7/9 | scsi: hisi_sas_v3: convert private reply queue to blk-mq hw queuedrivers/ drivers/ drivers/ | +36 | 8 replies | |
| 8/9 | scsi: megaraid: convert private reply queue to blk-mq hw queuedrivers/ drivers/ | +20 | 8 replies | |
| 9/9 | scsi: mp3sas: convert private reply queue to blk-mq hw queuedrivers/ drivers/ drivers/ | +31 | 2 replies |
Reviews trailers per patch
8 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Hannes Reinecke | Minwoo Im |
|---|---|---|
| 1/9 | R-b | |
| 2/9 | R-b | R-b |
| 3/9 | R-b | |
| 4/9 | R-b | R-b |
| 5/9 | R-b | |
| 6/9 | R-b | |
| 7/9 | ||
| 8/9 | R-b | |
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/9] blk-mq/scsi: convert private reply queue into blk_mq hw queue
Hi,
The 1st patch introduces support hostwide tags for multiple hw queues via the simplest approach to share single 'struct blk_mq_tags' instance among all hw queues. In theory, this way won't cause any performance drop. Even small IOPS improvement can be observed on random IO on null_blk/scsi_debug.
By applying the hostwide tags for MQ, we can convert some SCSI driver's private reply queue into generic blk-mq hw queue, then at least two improvement can be obtained:
1) the private reply queue maping can be removed from drivers, since the mapping has been implemented as generic API in blk-mq core
2) it helps to solve the generic managed IRQ race[1] during CPU hotplug in generic way, otherwise we have to re-invent new way to address the same issue for these drivers using private reply queue.
[1] https://lore.kernel.org/linux-block/[email protected]/T/#m6d95e2218bdd712ffda8f6451a0bb73eb2a651af
Any comment and test feedback are appreciated.
Thanks,
Ming
Hannes Reinecke (1):
scsi: Add template flag 'host_tagset'
Ming Lei (8):
blk-mq: allow hw queues to share hostwide tags
block: null_blk: introduce module parameter of 'g_host_tags'
scsi_debug: support host tagset
scsi: introduce scsi_cmnd_hctx_index()
scsi: hpsa: convert private reply queue to blk-mq hw queue
scsi: hisi_sas_v3: convert private reply queue to blk-mq hw queue
scsi: megaraid: convert private reply queue to blk-mq hw queue
scsi: mp3sas: convert private reply queue to blk-mq hw queue
block/blk-mq-debugfs.c | 1 + block/blk-mq-sched.c | 8 +++ block/blk-mq-tag.c | 6 ++ block/blk-mq.c | 14 ++++ block/elevator.c | 5 +- drivers/block/null_blk_main.c | 6 ++ drivers/scsi/hisi_sas/hisi_sas.h | 2 +- drivers/scsi/hisi_sas/hisi_sas_main.c | 36 +++++----- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 46 +++++-------- drivers/scsi/hpsa.c | 49 ++++++-------- drivers/scsi/megaraid/megaraid_sas_base.c | 50 +++++--------- drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 +- drivers/scsi/mpt3sas/mpt3sas_base.c | 74 ++++----------------- drivers/scsi/mpt3sas/mpt3sas_base.h | 3 +- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 17 +++++ drivers/scsi/scsi_debug.c | 3 + drivers/scsi/scsi_lib.c | 2 + include/linux/blk-mq.h | 1 + include/scsi/scsi_cmnd.h | 15 +++++ include/scsi/scsi_host.h | 3 + 20 files changed, 168 insertions(+), 177 deletions(-)
Signature · 1 line
2.20.1