Skip to content

crypto: make cra_driver_name mandatory

Eric Biggers linux-crypto 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2crypto: make all generic algorithms set cra_driver_namecrypto/anubis.c crypto/arc4.c crypto/crypto_null.c +19 more+55 -240 replies
2/2crypto: algapi - require cra_name and cra_driver_namecrypto/algapi.c+4 -180 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchArd Biesheuvel
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] crypto: make cra_driver_name mandatory

Most generic crypto algorithms declare a driver name ending in "-generic". The rest don't declare a driver name and instead rely on the crypto API automagically appending "-generic" upon registration.

Having multiple conventions is unnecessarily confusing and makes it harder to grep for all generic algorithms in the kernel source tree. But also, allowing NULL driver names is problematic because sometimes people fail to set it, e.g. the case fixed by commit 417980364300 ("crypto: cavium/zip - fix collision with generic cra_driver_name").

Of course, people can also incorrectly name their drivers "-generic". But that's much easier to notice / grep for.

Therefore, let's make cra_driver_name mandatory. Patch 1 gives all generic algorithms an explicit cra_driver_name, and Patch 2 makes cra_driver_name required for algorithm registration.

Eric Biggers (2):
crypto: make all generic algorithms set cra_driver_name
crypto: algapi - require cra_name and cra_driver_name

 crypto/algapi.c          | 22 ++++------------------
 crypto/anubis.c          |  1 +
 crypto/arc4.c            |  2 ++
 crypto/crypto_null.c     |  3 +++
 crypto/deflate.c         |  1 +
 crypto/fcrypt.c          |  1 +
 crypto/khazad.c          |  1 +
 crypto/lz4.c             |  1 +
 crypto/lz4hc.c           |  1 +
 crypto/lzo-rle.c         |  1 +
 crypto/lzo.c             |  1 +
 crypto/md4.c             |  7 ++++---
 crypto/md5.c             |  7 ++++---
 crypto/michael_mic.c     |  1 +
 crypto/rmd128.c          |  1 +
 crypto/rmd160.c          |  1 +
 crypto/rmd256.c          |  1 +
 crypto/rmd320.c          |  1 +
 crypto/serpent_generic.c |  1 +
 crypto/tea.c             |  3 +++
 crypto/tgr192.c          | 21 ++++++++++++---------
 crypto/wp512.c           | 21 ++++++++++++---------
 crypto/zstd.c            |  1 +
 23 files changed, 59 insertions(+), 42 deletions(-)
Signature · 1 line
2.21.0