Skip to content

qapi: block-dirty-bitmap-remove transaction action

Vladimir Sementsov-Ogievskiy qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4blockdev: reduce aio_context locked sections in bitmap add/removeblockdev.c+13 -171 reply
2/4block/dirty-bitmap: add hide/unhide APIblock/dirty-bitmap.c include/block/dirty-bitmap.h+28 -05 replies
3/4qapi: implement block-dirty-bitmap-remove transaction actionblockdev.c qapi/transaction.json+70 -62 replies
4/4iotests: test bitmap moving inside 254tests/qemu-iotests/254 tests/qemu-iotests/254.out+110 -20 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchJohn Snow
1/4R-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/4] qapi: block-dirty-bitmap-remove transaction action

Hi all!

Here is block-dirty-bitmap-remove transaction action.

It is used to do transactional movement of the bitmap (which is possible in conjunction with merge command). Transactional bitmap movement is needed in scenarios with external snapshot, when we don't want to leave copy of the bitmap in the base image.

Implementation itself in 03, in short:

.prepare: make bitmap unnamed and non-persistent, delete stored version
of the bitmap from the image

.commit: release bitmap

.abort: restore bitmap name and persistence. We don't restore bitmap
version in the image. It's not critical, we have in-RAM version, it will be stored on shutdown

Vladimir Sementsov-Ogievskiy (4):
blockdev: reduce aio_context locked sections in bitmap add/remove block/dirty-bitmap: add hide/unhide API
qapi: implement block-dirty-bitmap-remove transaction action
iotests: test bitmap moving inside 254

 qapi/transaction.json        |   2 +
 include/block/dirty-bitmap.h |   2 +
 block/dirty-bitmap.c         |  26 +++++++++
 blockdev.c                   | 100 +++++++++++++++++++++++++++--------
 tests/qemu-iotests/254       |  30 ++++++++++-
 tests/qemu-iotests/254.out   |  82 ++++++++++++++++++++++++++++
 6 files changed, 219 insertions(+), 23 deletions(-)
Signature · 1 line
2.18.0