Skip to content

rtc: pcf8563: Fix unhandled interrupt storm

Chen-Yu Tsai linux-arm-kernel linux-devicetree linux-rtc lkml 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3rtc: pcf8563: Fix interrupt trigger methoddrivers/rtc/rtc-pcf8563.c+1 -11 reply
2/3rtc: pcf8563: Clear event flags and disable interrupts before requesting irqdrivers/rtc/rtc-pcf8563.c+5 -61 reply
3/3arm64: dts: allwinner: h6: Pine H64: Add interrupt line for RTCarch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts+2 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] rtc: pcf8563: Fix unhandled interrupt storm

From: Chen-Yu Tsai <[email protected]>

Hi everyone,

While bringing up my Pine H64, I encountered an interrupt storm from the pcf8563 RTC. The RTC chip's interrupt line is shared with the PMIC, and was not properly added to the device tree. Also, the driver was using an trigger method incompatible with the PMIC, preventing the interrupt line from being shared. Last, the driver only clears and masks the alarm interrupt, while leaving the timer interrupt untouched. This is a problem if previous systems left the timer interrupt enabled, and there was an interrupt pending.

This patch set fixes all three issues, one per patch.

Please have a look.

Chen-Yu Tsai (3):
rtc: pcf8563: Fix interrupt trigger method
rtc: pcf8563: Clear event flags and disable interrupts before
requesting irq
arm64: dts: allwinner: h6: Pine H64: Add interrupt line for RTC

 .../arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts |  2 ++
 drivers/rtc/rtc-pcf8563.c                           | 13 ++++++-------
 2 files changed, 8 insertions(+), 7 deletions(-)
Signature · 1 line
2.20.1