Check for audio noise and pops
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest3 patches 3 repliesIn review
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | lib/igt_audio: detect noise and popslib/ | +53 | 1 reply | |
| 2/3 | lib/tests/igt_audio: add a pop testlib/ | +23 | 3 replies | |
| 3/3 | lib/tests/igt_audio: add phaseshift detection testlib/ | +36 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Martin Peres |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [igt-dev] [PATCH i-g-t v2 0/3] Check for audio noise and pops
This series is a continuation of "Add igt_audio self-tests and check for noise/pops". Comments have been addressed on the last two patches of that series, and a new commit adds a new phaseshift test.
In my real-world tests the power for these low frequencies go up to 0.0001 for DisplayPort. In the self-tests a 0.0005 threshold detects a phaseshift of at least 4 samples. Lowering the threshold to 0.0002 isn't enough to detect phaseshifts with a lower number of samples. Thus I still think a 0.0005 threshold is reasonable.
The phaseshift self-test truncates 8 samples, just so that we have some freedom if we want to change audio_signal_detect's logic. 8 samples is definitely a very small phaseshift.
Simon Ser (3):
lib/igt_audio: detect noise and pops lib/tests/igt_audio: add a pop test lib/tests/igt_audio: add phaseshift detection test
lib/igt_audio.c | 58 ++++++++++++++++++++++++++++++++++++++---- lib/tests/igt_audio.c | 59 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 112 insertions(+), 5 deletions(-)
--
2.21.0
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev