Skip to content

RFC Add PCIe support to TI's J721E SoC

Kishon Vijay Abraham I linux-arm-kernel linux-devicetree linux-omap linux-pci linux-rockchip lkml 1 version NAK

Status from this message: NAK

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest30 patches 4 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/30dt-bindings: PCI: cadence: Add DT binding to use PCIe with IOMMUDocumentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt+1 -00 replies
2/30dt-bindings: PCI: cadence: Add binding to reset PERST#Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt+1 -00 replies
3/30dt-bindings: PCI: cadence: Update host DT bindings with TI specific compatibleDocumentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt+1 -00 replies
4/30dt-bindings: PCI: cadence: Update EP DT bindings with TI specific compatibleDocumentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt+1 -00 replies
5/30linux/kernel.h: Add PTR_ALIGN_DOWN macroinclude/linux/kernel.h+1 -00 replies
6/30PCI: cadence: Add support to use custom read and write accessorsdrivers/pci/controller/pcie-cadence-ep.c drivers/pci/controller/pcie-cadence-host.c drivers/pci/controller/pcie-cadence.h+131 -90 replies
7/30PCI: cadence: Add read and write accessors to perform only 32-bit accessesdrivers/pci/controller/pcie-cadence.c drivers/pci/controller/pcie-cadence.h+42 -00 replies
8/30PCI: cadence: Add support to use PCIe in J721E SoCdrivers/pci/controller/pcie-cadence-ep.c drivers/pci/controller/pcie-cadence-host.c+55 -40 replies
9/30PCI: cadence: Add platform_data to start link and check link statusdrivers/pci/controller/pcie-cadence-ep.c drivers/pci/controller/pcie-cadence-host.c drivers/pci/controller/pcie-cadence.c +1 more+56 -00 replies
10/30PCI: cadence: Use *_start_link() and *_wait_for_link() to establish linkdrivers/pci/controller/pcie-cadence-ep.c drivers/pci/controller/pcie-cadence-host.c+21 -10 replies
11/30PCI: cadence: Add support to drive PERST# line using GPIOdrivers/pci/controller/pcie-cadence-host.c+26 -00 replies
12/30PCI: cadence: Make "mem" an optional memory resourcedrivers/pci/controller/pcie-cadence-ep.c drivers/pci/controller/pcie-cadence-host.c drivers/pci/controller/pcie-cadence.c+9 -80 replies
13/30PCI: cadence: Use local management register to configure Vendor IDdrivers/pci/controller/pcie-cadence-host.c+7 -20 replies
14/30PCI: endpoint: Use notification chain mechanism to notify EPC events to EPFdrivers/pci/endpoint/functions/pci-epf-test.c drivers/pci/endpoint/pci-epc-core.c drivers/pci/endpoint/pci-epf-core.c +2 more+23 -350 replies
15/30PCI: endpoint: Replace spinlock with mutexdrivers/pci/endpoint/pci-epc-core.c include/linux/pci-epc.h+34 -540 replies
16/30PCI: endpoint: Assign function number of each PF in EPC coredrivers/pci/endpoint/pci-ep-cfs.c drivers/pci/endpoint/pci-epc-core.c include/linux/pci-epc.h+18 -230 replies
17/30PCI: endpoint: Protect concurrent access to pci_epf_ops with mutexdrivers/pci/endpoint/pci-epf-core.c include/linux/pci-epf.h+13 -10 replies
18/30PCI: endpoint: Add support to add virtual function in endpoint coredrivers/pci/endpoint/pci-epc-core.c drivers/pci/endpoint/pci-epf-core.c include/linux/pci-epf.h+109 -30 replies
19/30PCI: endpoint: Add support to link a physical function to a virtual functiondrivers/pci/endpoint/pci-ep-cfs.c+24 -00 replies
20/30PCI: endpoint: Add virtual function number in pci_epc opsdrivers/pci/controller/dwc/pcie-designware-ep.c drivers/pci/controller/pcie-cadence-ep.c drivers/pci/controller/pcie-rockchip-ep.c +3 more+151 -1230 replies
21/30PCI: cadence: Add support to configure virtual functionsdrivers/pci/controller/pcie-cadence-ep.c drivers/pci/controller/pcie-cadence.h+98 -110 replies
22/30PCI: cadence: Configure pci_epc_features to align BAR addresses to 256 Bytesdrivers/pci/controller/pcie-cadence-ep.c+1 -00 replies
23/30of/platform: Export of_platform_device_create_pdata()drivers/of/platform.c include/linux/of_platform.h+7 -53 replies
24/30dt-bindings: PCI: J721E: Add DT bindings for PCIe controller in J721EDocumentation/devicetree/bindings/pci/ti,j721e-pci.txt include/dt-bindings/pci/pci.h+75 -00 replies
25/30PCI: j721e: Add TI J721E PCIe driverdrivers/pci/controller/Kconfig drivers/pci/controller/Makefile drivers/pci/controller/pci-j721e.c+441 -00 replies
26/30MAINTAINERS: Add MAINTAINER entry for PCIe on TI's J721E SoCMAINTAINERS+2 -11 reply
27/30misc: pci_endpoint_test: Add J721E in pci_device_id tabledrivers/misc/pci_endpoint_test.c+9 -00 replies
28/30misc: pci_endpoint_test: Avoid using module parameter to determine irqtypedrivers/misc/pci_endpoint_test.c+8 -30 replies
29/30misc: pci_endpoint_test: Populate sriov_configure ops to configure SRIOV devicedrivers/misc/pci_endpoint_test.c+1 -00 replies
30/30misc: pci_endpoint_test: Enable legacy interruptdrivers/misc/pci_endpoint_test.c+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 00/30] Add PCIe support to TI's J721E SoC

TI's J721E SoC uses Cadence PCIe core to implement both RC mode and EP mode.

The high level features are:
*) Supports Legacy, MSI and MSI-X interrupt
*) Supports upto GEN4 speed mode
*) Supports SR-IOV
*) Supports multipe physical function
*) Ability to route all transactions via SMMU

This patch series
*) Modify Cadence driver to be used for TI's J721E SoC *) Add a driver for J721E PCIe wrapper
*) Add SR-IOV support to PCI endpoint core and enable it in Cadence
driver
*) Other cleanups in endpoint core and pci_endpoint_test.c

I can split the series into sepearate series if that is preferred.

Initial support for J721E SoC is sent here [1].

[1] -> https://lkml.org/lkml/2019/5/22/593

Kishon Vijay Abraham I (30):
dt-bindings: PCI: cadence: Add DT binding to use PCIe with IOMMU
dt-bindings: PCI: cadence: Add binding to reset PERST#
dt-bindings: PCI: cadence: Update host DT bindings with TI specific
compatible
dt-bindings: PCI: cadence: Update EP DT bindings with TI specific
compatible
linux/kernel.h: Add PTR_ALIGN_DOWN macro
PCI: cadence: Add support to use custom read and write accessors
PCI: cadence: Add read and write accessors to perform only 32-bit
accesses
PCI: cadence: Add support to use PCIe in J721E SoC
PCI: cadence: Add platform_data to start link and check link status
PCI: cadence: Use *_start_link() and *_wait_for_link() to establish
link
PCI: cadence: Add support to drive PERST# line using GPIO
PCI: cadence: Make "mem" an optional memory resource
PCI: cadence: Use local management register to configure Vendor ID
PCI: endpoint: Use notification chain mechanism to notify EPC events
to EPF
PCI: endpoint: Replace spinlock with mutex
PCI: endpoint: Assign function number of each PF in EPC core
PCI: endpoint: Protect concurrent access to pci_epf_ops with mutex
PCI: endpoint: Add support to add virtual function in endpoint core
PCI: endpoint: Add support to link a physical function to a virtual
function
PCI: endpoint: Add virtual function number in pci_epc ops
PCI: cadence: Add support to configure virtual functions
PCI: cadence: Configure pci_epc_features to align BAR addresses to 256
Bytes
of/platform: Export of_platform_device_create_pdata()
dt-bindings: PCI: J721E: Add DT bindings for PCIe controller in J721E
PCI: j721e: Add TI J721E PCIe driver
MAINTAINERS: Add MAINTAINER entry for PCIe on TI's J721E SoC
misc: pci_endpoint_test: Add J721E in pci_device_id table
misc: pci_endpoint_test: Avoid using module parameter to determine
irqtype
misc: pci_endpoint_test: Populate sriov_configure ops to configure
SRIOV device
misc: pci_endpoint_test: Enable legacy interrupt

 .../bindings/pci/cdns,cdns-pcie-ep.txt        |   1 +
 .../bindings/pci/cdns,cdns-pcie-host.txt      |   3 +
 .../devicetree/bindings/pci/ti,j721e-pci.txt  |  63 +++
 MAINTAINERS                                   |   3 +-
 drivers/misc/pci_endpoint_test.c              |  22 +-
 drivers/of/platform.c                         |   9 +-
 drivers/pci/controller/Kconfig                |   9 +
 drivers/pci/controller/Makefile               |   1 +
 .../pci/controller/dwc/pcie-designware-ep.c   |  35 +-
 drivers/pci/controller/pci-j721e.c            | 431 ++++++++++++++++++
 drivers/pci/controller/pcie-cadence-ep.c      | 181 ++++++--
 drivers/pci/controller/pcie-cadence-host.c    | 119 ++++-
 drivers/pci/controller/pcie-cadence.c         |  87 +++-
 drivers/pci/controller/pcie-cadence.h         | 125 ++++-
 drivers/pci/controller/pcie-rockchip-ep.c     |  18 +-
 drivers/pci/endpoint/functions/pci-epf-test.c |  77 ++--
 drivers/pci/endpoint/pci-ep-cfs.c             |  51 ++-
 drivers/pci/endpoint/pci-epc-core.c           | 179 ++++----
 drivers/pci/endpoint/pci-epf-core.c           | 125 ++++-
 include/dt-bindings/pci/pci.h                 |  12 +
 include/linux/kernel.h                        |   1 +
 include/linux/of_platform.h                   |   3 +
 include/linux/pci-epc.h                       |  64 ++-
 include/linux/pci-epf.h                       |  27 +-
 24 files changed, 1365 insertions(+), 281 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pci/ti,j721e-pci.txt
 create mode 100644 drivers/pci/controller/pci-j721e.c
 create mode 100644 include/dt-bindings/pci/pci.h
Signature · 1 line
2.17.1