drm/i915: Fix TypeC port mode switching
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest23 patches 1 replyIn review
- v223 patches 21 repliesSuperseded
- v123 patches 42 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/23 | drm/i915/icl: Add support to read out the TBT PLL HW statedrivers/ | +9 | 0 replies | |
| 2/23 | drm/i915: Tune down WARNs about TBT AUX power well enablingdrivers/ | +11 | 0 replies | |
| 3/23 | drm/i915: Move the TypeC port handling code to a separate filedrivers/ drivers/ drivers/ +3 more | +256 | 0 replies | |
| 4/23 | drm/i915: Sanitize the terminology used for TypeC port modesdrivers/ drivers/ drivers/ +3 more | +31 | 0 replies | |
| 5/23 | drm/i915: Don't enable the DDI-IO power in the TypeC TBT-alt modedrivers/ | +8 | 0 replies | |
| 6/23 | drm/i915: Fix the TBT AUX power well enablingdrivers/ | +9 | 0 replies | |
| 7/23 | drm/i915: Use the correct AUX power domain in TypeC TBT-alt modedrivers/ | +19 | 0 replies | |
| 8/23 | drm/i915: Unify the TypeC port notation in debug/error messagesdrivers/ drivers/ drivers/ +1 more | +33 | 0 replies | |
| 9/23 | drm/i915: Factor out common parts from TypeC port handling functionsdrivers/ drivers/ drivers/ | +119 | 0 replies | |
| 10/23 | drm/i915: Wait for TypeC PHY complete flag to clear in safe modedrivers/ | +4 | 0 replies | |
| 11/23 | drm/i915: Handle the TCCOLD power-down eventdrivers/ | +29 | 0 replies | |
| 12/23 | drm/i915: Sanitize the TypeC connect/detect sequencesdrivers/ | +47 | 0 replies | |
| 13/23 | drm/i915: Fix the TypeC port mode sanitization during loading/resumedrivers/ drivers/ drivers/ +2 more | +104 | 0 replies | |
| 14/23 | drm/i915: Keep the TypeC port mode fixed for detect/AUX transfersdrivers/ drivers/ drivers/ +1 more | +39 | 0 replies | |
| 15/23 | drm/i915: Sanitize the TypeC FIA lane configuration decodingdrivers/ | +8 | 0 replies | |
| 16/23 | drm/i915: Sanitize the shared DPLL reserve/release interfacedrivers/ drivers/ drivers/ | +153 | 0 replies | |
| 17/23 | drm/i915: Sanitize the shared DPLL find/reference interfacedrivers/ | +70 | 0 replies | |
| 18/23 | drm/i915/icl: Split getting the DPLLs to port type specific functionsdrivers/ | +66 | 0 replies | |
| 19/23 | drm/i915/icl: Reserve all required PLLs for TypeC portsdrivers/ drivers/ drivers/ +1 more | +140 | 0 replies | |
| 20/23 | drm/i915: Keep the TypeC port mode fixed when the port is activedrivers/ drivers/ drivers/ +4 more | +243 | 0 replies | |
| 21/23 | drm/i915: Add state verification for the TypeC port modedrivers/ drivers/ drivers/ | +98 | 0 replies | |
| 22/23 | drm/i915: Remove unneeded disconnect in TypeC legacy port modedrivers/ drivers/ drivers/ | +4 | 0 replies | |
| 23/23 | drm/i915: WARN about invalid lane reversal in TBT-alt/DP-alt modesdrivers/ | +2 | 0 replies |
Reviews trailers per patch
All 23 patches have a Reviewed-by or Acked-by.
| Patch | José Roberto de Souza | Jani Nikula | Lucas De Marchi | Ville Syrjälä |
|---|---|---|---|---|
| 1/23 | R-b | |||
| 2/23 | R-b | |||
| 3/23 | R-b | A-b | ||
| 4/23 | R-b | |||
| 5/23 | R-b | |||
| 6/23 | R-b | |||
| 7/23 | R-b | |||
| 8/23 | R-b | |||
| 9/23 | R-b | |||
| 10/23 | R-b | |||
| 11/23 | R-b | |||
| 12/23 | R-b | R-b | ||
| 13/23 | R-b | |||
| 14/23 | R-b | |||
| 15/23 | R-b | |||
| 16/23 | R-b | |||
| 17/23 | R-b | |||
| 18/23 | R-b | |||
| 19/23 | R-b | |||
| 20/23 | R-b | |||
| 21/23 | R-b | |||
| 22/23 | R-b | |||
| 23/23 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v3 00/23] drm/i915: Fix TypeC port mode switching
This is v3 of [1] addressing the comments from Ville and adding the R-b lines everywhere.
[1] https://patchwork.freedesktop.org/series/61590/#rev3
Imre Deak (23):
drm/i915/icl: Add support to read out the TBT PLL HW state drm/i915: Tune down WARNs about TBT AUX power well enabling drm/i915: Move the TypeC port handling code to a separate file drm/i915: Sanitize the terminology used for TypeC port modes drm/i915: Don't enable the DDI-IO power in the TypeC TBT-alt mode drm/i915: Fix the TBT AUX power well enabling
drm/i915: Use the correct AUX power domain in TypeC TBT-alt mode drm/i915: Unify the TypeC port notation in debug/error messages drm/i915: Factor out common parts from TypeC port handling functions drm/i915: Wait for TypeC PHY complete flag to clear in safe mode drm/i915: Handle the TCCOLD power-down event
drm/i915: Sanitize the TypeC connect/detect sequences drm/i915: Fix the TypeC port mode sanitization during loading/resume drm/i915: Keep the TypeC port mode fixed for detect/AUX transfers drm/i915: Sanitize the TypeC FIA lane configuration decoding drm/i915: Sanitize the shared DPLL reserve/release interface drm/i915: Sanitize the shared DPLL find/reference interface drm/i915/icl: Split getting the DPLLs to port type specific functions drm/i915/icl: Reserve all required PLLs for TypeC ports drm/i915: Keep the TypeC port mode fixed when the port is active drm/i915: Add state verification for the TypeC port mode drm/i915: Remove unneeded disconnect in TypeC legacy port mode drm/i915: WARN about invalid lane reversal in TBT-alt/DP-alt modes
drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/display/intel_ddi.c | 124 +++-- drivers/gpu/drm/i915/display/intel_display.c | 166 +++++- drivers/gpu/drm/i915/display/intel_display.h | 7 +- .../drm/i915/display/intel_display_power.c | 108 +++- drivers/gpu/drm/i915/display/intel_dp.c | 236 +------- drivers/gpu/drm/i915/display/intel_dp.h | 2 - drivers/gpu/drm/i915/display/intel_dp_mst.h | 8 +- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 525 +++++++++++++----- drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 25 +- drivers/gpu/drm/i915/display/intel_tc.c | 468 ++++++++++++++++ drivers/gpu/drm/i915/display/intel_tc.h | 32 ++ drivers/gpu/drm/i915/intel_drv.h | 21 +- 13 files changed, 1250 insertions(+), 475 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_tc.c create mode 100644 drivers/gpu/drm/i915/display/intel_tc.h
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx