Skip to content

drm/i915: Fix TypeC port mode switching

Imre Deak intel-gfx 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest23 patches 1 replyIn review
  2. v223 patches 21 repliesSuperseded
  3. v123 patches 42 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23drm/i915/icl: Add support to read out the TBT PLL HW statedrivers/gpu/drm/i915/display/intel_display.c+9 -20 replies
2/23drm/i915: Tune down WARNs about TBT AUX power well enablingdrivers/gpu/drm/i915/display/intel_display_power.c+11 -50 replies
3/23drm/i915: Move the TypeC port handling code to a separate filedrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_dp.c +3 more+256 -2300 replies
4/23drm/i915: Sanitize the terminology used for TypeC port modesdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.h drivers/gpu/drm/i915/display/intel_dp.c +3 more+31 -410 replies
5/23drm/i915: Don't enable the DDI-IO power in the TypeC TBT-alt modedrivers/gpu/drm/i915/display/intel_ddi.c+8 -30 replies
6/23drm/i915: Fix the TBT AUX power well enablingdrivers/gpu/drm/i915/display/intel_display_power.c+9 -20 replies
7/23drm/i915: Use the correct AUX power domain in TypeC TBT-alt modedrivers/gpu/drm/i915/display/intel_display.c+19 -00 replies
8/23drm/i915: Unify the TypeC port notation in debug/error messagesdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_tc.c drivers/gpu/drm/i915/display/intel_tc.h +1 more+33 -110 replies
9/23drm/i915: Factor out common parts from TypeC port handling functionsdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_tc.c drivers/gpu/drm/i915/display/intel_tc.h+119 -810 replies
10/23drm/i915: Wait for TypeC PHY complete flag to clear in safe modedrivers/gpu/drm/i915/display/intel_tc.c+4 -00 replies
11/23drm/i915: Handle the TCCOLD power-down eventdrivers/gpu/drm/i915/display/intel_tc.c+29 -40 replies
12/23drm/i915: Sanitize the TypeC connect/detect sequencesdrivers/gpu/drm/i915/display/intel_tc.c+47 -490 replies
13/23drm/i915: Fix the TypeC port mode sanitization during loading/resumedrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_dp_mst.h +2 more+104 -160 replies
14/23drm/i915: Keep the TypeC port mode fixed for detect/AUX transfersdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_tc.c drivers/gpu/drm/i915/display/intel_tc.h +1 more+39 -10 replies
15/23drm/i915: Sanitize the TypeC FIA lane configuration decodingdrivers/gpu/drm/i915/display/intel_tc.c+8 -70 replies
16/23drm/i915: Sanitize the shared DPLL reserve/release interfacedrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_dpll_mgr.c drivers/gpu/drm/i915/display/intel_dpll_mgr.h+153 -1000 replies
17/23drm/i915: Sanitize the shared DPLL find/reference interfacedrivers/gpu/drm/i915/display/intel_dpll_mgr.c+70 -370 replies
18/23drm/i915/icl: Split getting the DPLLs to port type specific functionsdrivers/gpu/drm/i915/display/intel_dpll_mgr.c+66 -340 replies
19/23drm/i915/icl: Reserve all required PLLs for TypeC portsdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_dpll_mgr.c drivers/gpu/drm/i915/display/intel_dpll_mgr.h +1 more+140 -420 replies
20/23drm/i915: Keep the TypeC port mode fixed when the port is activedrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_dpll_mgr.c +4 more+243 -300 replies
21/23drm/i915: Add state verification for the TypeC port modedrivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_tc.c drivers/gpu/drm/i915/display/intel_tc.h+98 -90 replies
22/23drm/i915: Remove unneeded disconnect in TypeC legacy port modedrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_tc.c drivers/gpu/drm/i915/display/intel_tc.h+4 -230 replies
23/23drm/i915: WARN about invalid lane reversal in TBT-alt/DP-alt modesdrivers/gpu/drm/i915/display/intel_ddi.c+2 -00 replies

Reviews trailers per patch

All 23 patches have a Reviewed-by or Acked-by.

PatchJosé Roberto de SouzaJani NikulaLucas De MarchiVille Syrjälä
1/23R-b
2/23R-b
3/23R-b A-b
4/23R-b
5/23R-b
6/23R-b
7/23R-b
8/23R-b
9/23R-b
10/23R-b
11/23R-b
12/23R-b R-b
13/23R-b
14/23R-b
15/23R-b
16/23R-b
17/23R-b
18/23R-b
19/23R-b
20/23R-b
21/23R-b
22/23R-b
23/23R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/23] drm/i915: Fix TypeC port mode switching

This is v3 of [1] addressing the comments from Ville and adding the R-b lines everywhere.

[1] https://patchwork.freedesktop.org/series/61590/#rev3

Cc Manasi Navare <[email protected]>
Cc José Roberto de Souza <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Animesh Manna <[email protected]>
Cc Paulo Zanoni <[email protected]>
Cc Ville Syrjälä <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Anusha Srivatsa <[email protected]>
Cc Maarten Lankhorst <[email protected]>

Imre Deak (23):
drm/i915/icl: Add support to read out the TBT PLL HW state drm/i915: Tune down WARNs about TBT AUX power well enabling drm/i915: Move the TypeC port handling code to a separate file drm/i915: Sanitize the terminology used for TypeC port modes drm/i915: Don't enable the DDI-IO power in the TypeC TBT-alt mode drm/i915: Fix the TBT AUX power well enabling
drm/i915: Use the correct AUX power domain in TypeC TBT-alt mode drm/i915: Unify the TypeC port notation in debug/error messages drm/i915: Factor out common parts from TypeC port handling functions drm/i915: Wait for TypeC PHY complete flag to clear in safe mode drm/i915: Handle the TCCOLD power-down event
drm/i915: Sanitize the TypeC connect/detect sequences drm/i915: Fix the TypeC port mode sanitization during loading/resume drm/i915: Keep the TypeC port mode fixed for detect/AUX transfers drm/i915: Sanitize the TypeC FIA lane configuration decoding drm/i915: Sanitize the shared DPLL reserve/release interface drm/i915: Sanitize the shared DPLL find/reference interface drm/i915/icl: Split getting the DPLLs to port type specific functions drm/i915/icl: Reserve all required PLLs for TypeC ports drm/i915: Keep the TypeC port mode fixed when the port is active drm/i915: Add state verification for the TypeC port mode drm/i915: Remove unneeded disconnect in TypeC legacy port mode drm/i915: WARN about invalid lane reversal in TBT-alt/DP-alt modes

 drivers/gpu/drm/i915/Makefile                 |   3 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      | 124 +++--
 drivers/gpu/drm/i915/display/intel_display.c  | 166 +++++-
 drivers/gpu/drm/i915/display/intel_display.h  |   7 +-
 .../drm/i915/display/intel_display_power.c    | 108 +++-
 drivers/gpu/drm/i915/display/intel_dp.c       | 236 +-------
 drivers/gpu/drm/i915/display/intel_dp.h       |   2 -
 drivers/gpu/drm/i915/display/intel_dp_mst.h   |   8 +-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 525 +++++++++++++-----
 drivers/gpu/drm/i915/display/intel_dpll_mgr.h |  25 +-
 drivers/gpu/drm/i915/display/intel_tc.c       | 468 ++++++++++++++++
 drivers/gpu/drm/i915/display/intel_tc.h       |  32 ++
 drivers/gpu/drm/i915/intel_drv.h              |  21 +-
 13 files changed, 1250 insertions(+), 475 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_tc.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_tc.h
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx