Skip to content

Deep review of 'AS IS' disclaimers - part 1

Thomas Gleixner linux-spdx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 124drivers/regulator/tps65132-regulator.c+1 -101 reply
2/6treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 304arch/arm/boot/dts/bcm11351.dtsi arch/arm/boot/dts/bcm21664-garnet.dts arch/arm/boot/dts/bcm21664.dtsi +28 more+31 -2741 reply
3/6treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 317drivers/mfd/tps80031.c drivers/pinctrl/pinctrl-as3722.c drivers/pinctrl/pinctrl-palmas.c +9 more+12 -1681 reply
4/6treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 318drivers/gpio/gpio-bd9571mwv.c drivers/gpio/gpio-lp873x.c drivers/gpio/gpio-lp87565.c +17 more+20 -1801 reply
5/6treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 319arch/arm/mach-omap1/timer.c arch/arm/mach-omap2/display.c arch/arm/mach-omap2/omap_opp_data.h +37 more+40 -3541 reply
6/6treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 413arch/arm/mach-omap2/omap_hwmod_reset.c include/sound/aess.h+2 -281 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEnrico WeigeltAllison Randal
SeriesR-b
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [ASIS-1 patch 0/6] Deep review of 'AS IS' disclaimers - part 1

Folks,

after finishing the boring big sort out phase, we're now at the point to look at the patches on hold.

I've sorted the on hold patches into categories with matching patterns so we can look at each pattern separately.

The first batch is from the 'AS IS' category. All patches in this series have the same modification of the standard GPLv2 disclaimer.

Standard disclaimer:

this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose

Modified diclaimer:

this program is distributed as is without any warranty of any kind whether express[ed] or implied without even the implied warranty of merchantability or fitness for a particular purpose

The NO WARRANTY section of the GPLv2 contains:

PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE

In my opinion the modified disclaimer contains nothing which is substantially different, but I might be wrong as usual.

In case we agree on that, I would amend the changelogs of the individual patches with a paragraph explaining our conclusion. Something along the lines:

The patterns deviate from the standard GPLv2 disclaimer, but the modification does not expand beyond the standard disclaimer and the NO WARRANTY section of the GPLv2. So replacing the license notice including the modified disclaimer with the SPDX license identifier results in the same protections and conditions.

Feel free to suggest better wording or deeper explanation.

Thanks,

tglx