RFC watchdog/softlockup: Make softlockup reports more reliable and useful
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest3 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | watchdog/softlockup: Preserve original timestamp when touching watchdog externallykernel/ | +26 | 0 replies | |
| 2/3 | watchdog/softlockup: Report the same softlockup regularlykernel/ | +1 | 0 replies | |
| 3/3 | Test softlockupfs/ fs/ kernel/ | +36 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC 0/3] watchdog/softlockup: Make softlockup reports more reliable and useful
Hi,
we were analyzing logs with several softlockup reports in flush_tlb_kernel_range(). They were confusing. Especially it was not clear whether it was deadlock, livelock, or separate softlockups.
It went out that even a simple busy loop:
while (true) cpu_relax();
is able to produce several softlockups reports:
[ 168.277520] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [cat:4865] [ 196.277604] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [cat:4865] [ 236.277522] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [cat:4865]
I tried to understand the tricky watchdog code and produced two patches that would be helpful to debug the original real bug:
1st patch prevents restart of the watchdog from unrelated locations.
2nd patch helps to distinguish several possible situations by regular reports.
3rd patch can be used for testing the problem.
The watchdog code might deserve even more clean up. Anyway, I would like to hear other's opinion first.
Petr Mladek (3):
watchdog/softlockup: Preserve original timestamp when touching
watchdog externally
watchdog/softlockup: Report the same softlockup regularly Test softlockup
fs/proc/consoles.c | 5 ++++ fs/proc/version.c | 7 +++++ kernel/watchdog.c | 85 +++++++++++++++++++++++++++++++----------------------- 3 files changed, 61 insertions(+), 36 deletions(-)
Signature · 1 line
2.16.4