Skip to content

migration/multifd: a new mechanism for send thread sync

Wei Yang qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 3 repliesIn review
  2. v16 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6migration/multifd: move Params update and pages cleanup into multifd_send_fill_packet()migration/ram.c+11 -92 replies
2/6migration/multifd: notify channels_ready when send thread startsmigration/ram.c+2 -00 replies
3/6migration/multifd: use sync field to synchronize send threadsmigration/ram.c+24 -60 replies
4/6migration/multifd: used must not be 0 for a pending jobmigration/ram.c+5 -60 replies
5/6migration/multifd: use boolean for pending_job is enoughmigration/ram.c+4 -50 replies
6/6migration/multifd: there is no spurious wakeup nowmigration/ram.c+2 -20 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchJuan Quintela
1/6R-b
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] migration/multifd: a new mechanism for send thread sync

Current send thread could work while the sync mechanism has some problem:

* has spuriously wakeup
* number of channels_ready will *overflow* the number of real channels

The reason is:

* if MULTIFD_FLAG_SYNC is set in the middle of send thread running, there is one more spurious wakeup
* if MULTIFD_FLAG_SYNC is set when send thread is not running, there is one more channels_ready be triggered

To solve this situation, one new mechanism is introduced to synchronize send threads. The idea is simple, a new field *sync* is introduced to indicate a synchronization is required.

---
v2: rebase on latest code

Wei Yang (6):
migration/multifd: move Params update and pages cleanup into
multifd_send_fill_packet()
migration/multifd: notify channels_ready when send thread starts migration/multifd: use sync field to synchronize send threads migration/multifd: used must not be 0 for a pending job migration/multifd: use boolean for pending_job is enough migration/multifd: there is no spurious wakeup now

 migration/ram.c | 74 +++++++++++++++++++++++++++++++------------------
 1 file changed, 47 insertions(+), 27 deletions(-)
Signature · 1 line
2.17.1