Skip to content

RFC Implicit dev_priv removal

Tvrtko Ursulin intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest14 patches 13 repliesIn review
  2. v121 patches 24 repliesSuperseded

Changes in v2 from the cover letter

* Introduce struct intel_gt by popular demand.
* Compile tested only this time.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14drm/i915: Make i915_check_and_clear_faults take uncoredrivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_reset.c drivers/gpu/drm/i915/gt/intel_reset.h +2 more+20 -185 replies
2/14drm/i915: Convert intel_vgt_(de)balloon to uncoredrivers/gpu/drm/i915/i915_gem_gtt.c drivers/gpu/drm/i915/i915_vgpu.c drivers/gpu/drm/i915/i915_vgpu.h+18 -140 replies
3/14drm/i915: Introduce struct intel_gt as replacement for anonymous i915->gtdrivers/gpu/drm/i915/gt/intel_gt_types.h drivers/gpu/drm/i915/i915_drv.h+55 -320 replies
4/14drm/i915: Add a couple intel_gt helpersdrivers/gpu/drm/i915/gt/intel_gt.h+26 -01 reply
5/14drm/i915: Convert i915_gem_init_swizzling to intel_gtdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/gt/intel_gt.c drivers/gpu/drm/i915/gt/intel_gt.h +3 more+52 -270 replies
6/14drm/i915: Convert init_unused_rings to intel_gtdrivers/gpu/drm/i915/i915_gem.c+23 -190 replies
7/14drm/i915: Convert gt workarounds to intel_gtdrivers/gpu/drm/i915/gt/intel_workarounds.c drivers/gpu/drm/i915/gt/intel_workarounds.h drivers/gpu/drm/i915/i915_gem.c+11 -100 replies
8/14drm/i915: Store backpointer to intel_gt in the enginedrivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_engine_types.h+3 -05 replies
9/14drm/i915: Convert intel_mocs_init_l3cc_table to intel_gtdrivers/gpu/drm/i915/gt/intel_mocs.c drivers/gpu/drm/i915/gt/intel_mocs.h drivers/gpu/drm/i915/i915_gem.c+35 -220 replies
10/14drm/i915: Convert i915_ppgtt_init_hw to intel_gtdrivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gem_gtt.c drivers/gpu/drm/i915/i915_gem_gtt.h+68 -390 replies
11/14drm/i915: Consolidate some open coded mmio rmwdrivers/gpu/drm/i915/i915_gem_gtt.c+18 -230 replies
12/14drm/i915: Convert i915_gem_init_hw to intel_gtdrivers/gpu/drm/i915/i915_gem.c+41 -270 replies
13/14drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_sizedrivers/gpu/drm/i915/i915_gem_gtt.c drivers/gpu/drm/i915/intel_guc.c drivers/gpu/drm/i915/intel_guc.h +1 more+18 -191 reply
14/14drm/i915: Make GuC GGTT reservation work on ggttdrivers/gpu/drm/i915/i915_gem_gtt.c drivers/gpu/drm/i915/intel_guc.c drivers/gpu/drm/i915/intel_guc.h+30 -361 reply

Reviews trailers per patch

4 of 14 patches have a Reviewed-by or Acked-by.

PatchRodrigo ViviChris WilsonMichal Wajdeczko
1/14R-b
2/14
3/14
4/14
5/14
6/14
7/14
8/14
9/14
10/14
11/14R-b
12/14
13/14R-b
14/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [RFC v2 00/14] Implicit dev_priv removal

From: Tvrtko Ursulin <[email protected]>

Mostly patches reworking the code and GEM init paths to remove some implicit dev_priv dependencies (I915_READ/I915_WRITE), plus some small tweaks to tidy GEM init paths to use more logical input parameters (enabled by the conversion to uncore mmio accessors).

v2:
* Introduce struct intel_gt by popular demand.
* Compile tested only this time.

Tvrtko Ursulin (14):
drm/i915: Make i915_check_and_clear_faults take uncore drm/i915: Convert intel_vgt_(de)balloon to uncore drm/i915: Introduce struct intel_gt as replacement for anonymous

    i915->gt

drm/i915: Add a couple intel_gt helpers
drm/i915: Convert i915_gem_init_swizzling to intel_gt drm/i915: Convert init_unused_rings to intel_gt
drm/i915: Convert gt workarounds to intel_gt
drm/i915: Store backpointer to intel_gt in the engine drm/i915: Convert intel_mocs_init_l3cc_table to intel_gt drm/i915: Convert i915_ppgtt_init_hw to intel_gt
drm/i915: Consolidate some open coded mmio rmw
drm/i915: Convert i915_gem_init_hw to intel_gt drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_size drm/i915: Make GuC GGTT reservation work on ggtt

 drivers/gpu/drm/i915/Makefile                |   1 +
 drivers/gpu/drm/i915/gt/intel_engine_cs.c    |   3 +-
 drivers/gpu/drm/i915/gt/intel_engine_types.h |   2 +
 drivers/gpu/drm/i915/gt/intel_gt.c           |  44 ++++++
 drivers/gpu/drm/i915/gt/intel_gt.h           |  28 ++++
 drivers/gpu/drm/i915/gt/intel_gt_types.h     |  53 +++++++
 drivers/gpu/drm/i915/gt/intel_mocs.c         |  52 ++++---
 drivers/gpu/drm/i915/gt/intel_mocs.h         |   3 +-
 drivers/gpu/drm/i915/gt/intel_reset.c        |  28 ++--
 drivers/gpu/drm/i915/gt/intel_reset.h        |   2 +-
 drivers/gpu/drm/i915/gt/intel_workarounds.c  |  11 +-
 drivers/gpu/drm/i915/gt/intel_workarounds.h  |   6 +-
 drivers/gpu/drm/i915/i915_drv.c              |   7 +-
 drivers/gpu/drm/i915/i915_drv.h              |  35 +----
 drivers/gpu/drm/i915/i915_gem.c              | 130 ++++++++--------
 drivers/gpu/drm/i915/i915_gem_gtt.c          | 148 ++++++++++++-------
 drivers/gpu/drm/i915/i915_gem_gtt.h          |   3 +-
 drivers/gpu/drm/i915/i915_vgpu.c             |  24 +--
 drivers/gpu/drm/i915/i915_vgpu.h             |   4 +-
 drivers/gpu/drm/i915/intel_guc.c             |  44 ------
 drivers/gpu/drm/i915/intel_guc.h             |   3 -
 drivers/gpu/drm/i915/intel_wopcm.h           |  17 +++
 22 files changed, 390 insertions(+), 258 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/gt/intel_gt.c
 create mode 100644 drivers/gpu/drm/i915/gt/intel_gt.h
 create mode 100644 drivers/gpu/drm/i915/gt/intel_gt_types.h
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx