Skip to content

file-posix: Add dynamic-auto-read-only QAPI feature

Markus Armbruster qemu-devel 1 version Applied

Status from this message: Queued, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 4 repliesApplied

v5 from the cover letter

- PATCH 4: restore a lost comment line, clean up comment whitespace for PEP 8
- PATCH 4+5: replace QAPIDoc._check_named_section() by ._is_section_tag()
- PATCH 7: New

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/7qapi: Add feature flags to struct typesdocs/devel/qapi-code-gen.txt qapi/introspect.json scripts/qapi/common.py +7 more+114 -180 replies
2/7tests/qapi-schema: Test for good feature lists in structstests/qapi-schema/qapi-schema-test.json tests/qapi-schema/qapi-schema-test.out tests/qapi-schema/test-qapi.py +1 more+94 -00 replies
3/7tests/qapi-schema: Error case tests for features in structstests/Makefile.include tests/qapi-schema/features-bad-type.err tests/qapi-schema/features-bad-type.exit +22 more+37 -00 replies
4/7qapi: Disentangle QAPIDoc codescripts/qapi/common.py+102 -250 replies
5/7qapi: Allow documentation for featuresscripts/qapi/common.py scripts/qapi/doc.py+51 -40 replies
6/7file-posix: Add dynamic-auto-read-only QAPI featureqapi/block-core.json+12 -12 replies
7/7qapi: Simplify QAPIDoc implements its state machinescripts/qapi/common.py+68 -570 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKevin Wolf
SeriesR-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/7] file-posix: Add dynamic-auto-read-only QAPI feature

This series adds optional feature lists to struct definitions in the QAPI schema and makes use of them to advertise the new behaviour of auto-read-only=on in file-posix.

v5:
- PATCH 4: restore a lost comment line, clean up comment whitespace for PEP 8
- PATCH 4+5: replace QAPIDoc._check_named_section() by ._is_section_tag()
- PATCH 7: New

v4:
- Build fix for tests/test-qmp-cmds

v3:
- Added a command using the structs types to the positive test case
- Renamed QAPIDoc.SymbolPart to QAPIDoc.DocPart
- Applied requested comment changes
- Style fixes to avoid adding pycodestyle-3 complaints
- More stylistic changes to match Markus' taste better

v2:
- Check that features have well-formed names instead of just checking that they are strings
- Use QAPISchemaFeature objects instead of dicts
- Catch duplicate feature names (and test that a feature name doesn't conflict with an object member)
- Added patch 4 and 5 to add rudimentary support for features to QAPIDoc so it doesn't complain about the documentation format suggested by Markus. Used that format in the documentation of dynamic-auto-read-only.

Kevin Wolf (6):
qapi: Add feature flags to struct types tests/qapi-schema: Test for good feature lists in structs tests/qapi-schema: Error case tests for features in structs
qapi: Disentangle QAPIDoc code
qapi: Allow documentation for features
file-posix: Add dynamic-auto-read-only QAPI feature

Markus Armbruster (1):
qapi: Simplify QAPIDoc implements its state machine

 docs/devel/qapi-code-gen.txt                  |  38 +++
 qapi/block-core.json                          |  13 +-
 qapi/introspect.json                          |   6 +-
 scripts/qapi/common.py                        | 243 +++++++++++++++---
 scripts/qapi/doc.py                           |  15 +-
 scripts/qapi/introspect.py                    |   6 +-
 scripts/qapi/types.py                         |   3 +-
 scripts/qapi/visit.py                         |   3 +-
 tests/Makefile.include                        |   6 +
 tests/qapi-schema/double-type.err             |   2 +-
 tests/qapi-schema/features-bad-type.err       |   1 +
 tests/qapi-schema/features-bad-type.exit      |   1 +
 tests/qapi-schema/features-bad-type.json      |   3 +
 tests/qapi-schema/features-bad-type.out       |   0
 tests/qapi-schema/features-duplicate-name.err |   1 +
 .../qapi-schema/features-duplicate-name.exit  |   1 +
 .../qapi-schema/features-duplicate-name.json  |   3 +
 tests/qapi-schema/features-duplicate-name.out |   0
 tests/qapi-schema/features-missing-name.err   |   1 +
 tests/qapi-schema/features-missing-name.exit  |   1 +
 tests/qapi-schema/features-missing-name.json  |   3 +
 tests/qapi-schema/features-missing-name.out   |   0
 tests/qapi-schema/features-name-bad-type.err  |   1 +
 tests/qapi-schema/features-name-bad-type.exit |   1 +
 tests/qapi-schema/features-name-bad-type.json |   3 +
 tests/qapi-schema/features-name-bad-type.out  |   0
 tests/qapi-schema/features-no-list.err        |   1 +
 tests/qapi-schema/features-no-list.exit       |   1 +
 tests/qapi-schema/features-no-list.json       |   3 +
 tests/qapi-schema/features-no-list.out        |   0
 tests/qapi-schema/features-unknown-key.err    |   2 +
 tests/qapi-schema/features-unknown-key.exit   |   1 +
 tests/qapi-schema/features-unknown-key.json   |   3 +
 tests/qapi-schema/features-unknown-key.out    |   0
 tests/qapi-schema/qapi-schema-test.json       |  39 +++
 tests/qapi-schema/qapi-schema-test.out        |  43 ++++
 tests/qapi-schema/test-qapi.py                |   7 +-
 tests/qapi-schema/unknown-expr-key.err        |   2 +-
 tests/test-qmp-cmds.c                         |   8 +
 39 files changed, 419 insertions(+), 46 deletions(-)
 create mode 100644 tests/qapi-schema/features-bad-type.err
 create mode 100644 tests/qapi-schema/features-bad-type.exit
 create mode 100644 tests/qapi-schema/features-bad-type.json
 create mode 100644 tests/qapi-schema/features-bad-type.out
 create mode 100644 tests/qapi-schema/features-duplicate-name.err
 create mode 100644 tests/qapi-schema/features-duplicate-name.exit
 create mode 100644 tests/qapi-schema/features-duplicate-name.json
 create mode 100644 tests/qapi-schema/features-duplicate-name.out
 create mode 100644 tests/qapi-schema/features-missing-name.err
 create mode 100644 tests/qapi-schema/features-missing-name.exit
 create mode 100644 tests/qapi-schema/features-missing-name.json
 create mode 100644 tests/qapi-schema/features-missing-name.out
 create mode 100644 tests/qapi-schema/features-name-bad-type.err
 create mode 100644 tests/qapi-schema/features-name-bad-type.exit
 create mode 100644 tests/qapi-schema/features-name-bad-type.json
 create mode 100644 tests/qapi-schema/features-name-bad-type.out
 create mode 100644 tests/qapi-schema/features-no-list.err
 create mode 100644 tests/qapi-schema/features-no-list.exit
 create mode 100644 tests/qapi-schema/features-no-list.json
 create mode 100644 tests/qapi-schema/features-no-list.out
 create mode 100644 tests/qapi-schema/features-unknown-key.err
 create mode 100644 tests/qapi-schema/features-unknown-key.exit
 create mode 100644 tests/qapi-schema/features-unknown-key.json
 create mode 100644 tests/qapi-schema/features-unknown-key.out
Signature · 1 line
2.21.0