Skip to content

media: Access videobuf2 buffers via an accessor

Ezequiel Garcia linux-media 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 2 repliesIn review
  2. v15 patches 4 repliesSuperseded

Changes in v2 from the cover letter

* Address feedback from Boris, and drop redundant check.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5media: vb2: Introduce a vb2_get_buffer accessorinclude/media/videobuf2-core.h+18 -01 reply
2/5media: mtk-jpeg: Use vb2_get_bufferdrivers/media/platform/mtk-jpeg/mtk_jpeg_core.c+1 -10 replies
3/5media: mtk-vcodec: Use vb2_get_bufferdrivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c+9 -30 replies
4/5media: sti: Use vb2_get_bufferdrivers/media/platform/sti/hva/hva-v4l2.c+3 -10 replies
5/5media: rockchip: Use vb2_get_bufferdrivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c+6 -32 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchBoris BrezillonMarek Szyprowski
1/5R-b A-b
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] media: Access videobuf2 buffers via an accessor

Hi,

This patchset introduces a new vb2_get_buffer accessor and then uses it on all the drivers that are accessing videobuf2 private buffer array directly.

I'm skipping Intel IPU3 driver here, since the code goes beyond just accessing the buffer. It also modifies the buffer queue directly. I believe this driver would need some more cleanup and love from its maintainers.

Note that OMAP2/OMAP3 display driver is videobuf1 and so not affected by this change.

Lastly, note that I'm doing the minimum changes to drivers I can't test, only using the new accessor and avoiding any further changes.

Changes from v1:

* Address feedback from Boris, and drop redundant check.

Thanks,
Ezequiel

Ezequiel Garcia (5):
media: vb2: Introduce a vb2_get_buffer accessor
media: mtk-jpeg: Use vb2_get_buffer
media: mtk-vcodec: Use vb2_get_buffer
media: sti: Use vb2_get_buffer
media: rockchip: Use vb2_get_buffer

 .../media/platform/mtk-jpeg/mtk_jpeg_core.c    |  2 +-
 .../media/platform/mtk-vcodec/mtk_vcodec_enc.c | 12 +++++++++---
 drivers/media/platform/sti/hva/hva-v4l2.c      |  4 +++-
 .../media/rockchip/vpu/rockchip_vpu_drv.c      |  9 ++++++---
 include/media/videobuf2-core.h                 | 18 ++++++++++++++++++
 5 files changed, 37 insertions(+), 8 deletions(-)
Signature · 1 line
2.20.1