Skip to content

block/dirty-bitmap: check number and size constraints against queued bitmaps

John Snow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 23 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5block/qcow2-bitmap: allow bitmap_list_load to return an error codeblock/qcow2-bitmap.c+28 -362 replies
2/5block/dirty-bitmap: Refactor bdrv_can_store_new_bitmapblock.c block/dirty-bitmap.c block/qcow2-bitmap.c +6 more+68 -528 replies
3/5block/dirty-bitmap: rework bdrv_remove_persistent_dirty_bitmapblock/dirty-bitmap.c block/qcow2-bitmap.c block/qcow2.h +3 more+44 -303 replies
4/5block/qcow2-bitmap: Count queued bitmaps towards nb_bitmapsblock/dirty-bitmap.c block/qcow2-bitmap.c block/qcow2.h+30 -104 replies
5/5block/qcow2-bitmap: Count queued bitmaps towards directory_sizeblock/qcow2-bitmap.c block/qcow2.h+13 -12 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchEric BlakeVladimir Sementsov-Ogievskiy
1/5R-b R-b
2/5R-b R-b
3/5R-b R-b
4/5R-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/5] block/dirty-bitmap: check number and size constraints against queued bitmaps

When adding new persistent dirty bitmaps, we only check constraints against currently stored bitmaps, and ignore the pending number and size of any bitmaps yet to be stored.

Rework the "can_store" and "remove" interface to explicit "add" and "remove", and begin keeping track of the queued burden when adding new bitmaps.

John Snow (5):
block/qcow2-bitmap: allow bitmap_list_load to return an error code block/dirty-bitmap: Refactor bdrv_can_store_new_bitmap block/dirty-bitmap: rework bdrv_remove_persistent_dirty_bitmap block/qcow2-bitmap: Count queued bitmaps towards nb_bitmaps block/qcow2-bitmap: Count queued bitmaps towards directory_size

 block/qcow2.h                |  13 ++--
 include/block/block.h        |   2 -
 include/block/block_int.h    |  11 ++-
 include/block/dirty-bitmap.h |   9 ++-
 block.c                      |  22 ------
 block/dirty-bitmap.c         |  71 +++++++++++++++---
 block/qcow2-bitmap.c         | 140 +++++++++++++++++++++--------------
 block/qcow2.c                |   2 +-
 blockdev.c                   |  34 ++++-----
 9 files changed, 179 insertions(+), 125 deletions(-)
Signature · 1 line
2.20.1