Skip to content

RFC Legacy mmio accessor macro pruning

Tvrtko Ursulin intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest12 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12drm/i915: Eliminate unused mmio accessorsdrivers/gpu/drm/i915/i915_drv.h+0 -40 replies
2/12drm/i915: Convert i915_reg_read_ioctl to use explicit mmio accessorsdrivers/gpu/drm/i915/intel_uncore.c+14 -90 replies
3/12drm/i915: Convert icl_get_stolen_reserved to uncore mmio accessorsdrivers/gpu/drm/i915/gem/i915_gem_stolen.c+2 -20 replies
4/12drm/i915: Convert gem_record_fences to uncore mmio accessorsdrivers/gpu/drm/i915/i915_gpu_error.c+9 -30 replies
5/12drm/i915: Convert intel_read_wm_latency to uncore mmio accessorsdrivers/gpu/drm/i915/intel_pm.c+5 -30 replies
6/12drm/i915: Remove I915_READ64 and I915_READ64_32x2drivers/gpu/drm/i915/i915_drv.h+0 -181 reply
7/12drm/i915: Remove I915_READ8drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_crt.c drivers/gpu/drm/i915/intel_pm.c+26 -236 replies
8/12drm/i915: Remove I915_POSTING_READ_FWdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_irq.c +2 more+24 -231 reply
9/12drm/i915: Remove POSTING_READ16drivers/gpu/drm/i915/gt/intel_engine.h drivers/gpu/drm/i915/gt/intel_ringbuffer.c drivers/gpu/drm/i915/i915_drv.h +1 more+11 -101 reply
10/12drm/i915: Remove I915_WRITE_NOTRACEdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_gmbus.c+27 -161 reply
11/12drm/i915: Remove I915_READ_NOTRACEdrivers/gpu/drm/i915/gvt/debugfs.c drivers/gpu/drm/i915/gvt/firmware.c drivers/gpu/drm/i915/i915_drv.c +4 more+43 -351 reply
12/12drm/i915: Remove I915_READ16 and I915_WRITE16drivers/gpu/drm/i915/gt/intel_ringbuffer.c drivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h +3 more+161 -1221 reply

Reviews trailers per patch

7 of 12 patches have a Reviewed-by or Acked-by.

PatchJani Nikula
1/12
2/12
3/12
4/12
5/12
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 00/12] Legacy mmio accessor macro pruning

From: Tvrtko Ursulin <[email protected]>

Since we want to stop using the legacy mmio accessors (the ones which create a hidden dependency to having a dev_priv local) this series removes all of the more exotic ones by converting the call sites to use the new uncore accessors.

The ones left are only the standard 32-bit ones and the _FW suffix flavour. It will be a much bigger (more invasive) task to get rid of those.

But even though this series only results in a partial conversion, benefit is that with removed macros there is no chance to use them by accident in new code.

Tvrtko Ursulin (12):
drm/i915: Eliminate unused mmio accessors
drm/i915: Convert i915_reg_read_ioctl to use explicit mmio accessors drm/i915: Convert icl_get_stolen_reserved to uncore mmio accessors drm/i915: Convert gem_record_fences to uncore mmio accessors drm/i915: Convert intel_read_wm_latency to uncore mmio accessors drm/i915: Remove I915_READ64 and I915_READ64_32x2 drm/i915: Remove I915_READ8
drm/i915: Remove I915_POSTING_READ_FW
drm/i915: Remove POSTING_READ16
drm/i915: Remove I915_WRITE_NOTRACE
drm/i915: Remove I915_READ_NOTRACE
drm/i915: Remove I915_READ16 and I915_WRITE16

 drivers/gpu/drm/i915/gem/i915_gem_stolen.c  |   4 +-
 drivers/gpu/drm/i915/gt/intel_engine.h      |   1 +
 drivers/gpu/drm/i915/gt/intel_ringbuffer.c  |  14 +-
 drivers/gpu/drm/i915/gvt/debugfs.c          |   4 +-
 drivers/gpu/drm/i915/gvt/firmware.c         |   5 +-
 drivers/gpu/drm/i915/i915_debugfs.c         |  37 ++---
 drivers/gpu/drm/i915/i915_drv.c             |   6 +-
 drivers/gpu/drm/i915/i915_drv.h             |  31 ----
 drivers/gpu/drm/i915/i915_gem.c             |   9 +-
 drivers/gpu/drm/i915/i915_gpu_error.c       | 116 ++++++++-------
 drivers/gpu/drm/i915/i915_irq.c             |  42 +++---
 drivers/gpu/drm/i915/i915_pmu.c             |   8 +-
 drivers/gpu/drm/i915/intel_crt.c            |  41 +++---
 drivers/gpu/drm/i915/intel_dp.c             |  43 +++---
 drivers/gpu/drm/i915/intel_gmbus.c          |  53 ++++---
 drivers/gpu/drm/i915/intel_guc_submission.c |   4 +-
 drivers/gpu/drm/i915/intel_pm.c             | 149 +++++++++++---------
 drivers/gpu/drm/i915/intel_uncore.c         |  23 +--
 18 files changed, 322 insertions(+), 268 deletions(-)
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx