Skip to content

bonding: clean up and standarize logging printks

Jarod Wilson lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7bonding: improve event debug usabilitydrivers/net/bonding/bond_main.c+2 -10 replies
2/7bonding: fix error messages in bond_do_fail_over_macdrivers/net/bonding/bond_main.c+5 -50 replies
3/7bonding: add slave_foo printk macrosinclude/net/bonding.h+9 -00 replies
4/7bonding/main: convert to using slave printk macrosdrivers/net/bonding/bond_main.c+139 -1670 replies
5/7bonding/802.3ad: convert to using slave printk macrosdrivers/net/bonding/bond_3ad.c+116 -1060 replies
6/7bonding/alb: convert to using slave printk macrosdrivers/net/bonding/bond_alb.c+15 -150 replies
7/7bonding/options: convert to using slave printk macrosdrivers/net/bonding/bond_options.c+12 -180 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/7] bonding: clean up and standarize logging printks

This set improves a few somewhat terse bonding debug messages, fixes some errors in others, and then standarizes the majority of them, using new slave_* printk macros that wrap around netdev_* to ensure both master and slave information is provided consistently, where relevant. This set proves very useful in debugging issues on hosts with multiple bonds.

I've run an array of LNST tests over this set, creating and destroying quite a few different bonds of the course of testing, fixed the little gotchas here and there, and everything looks stable and reasonable to me, but I can't guarantee I've tested every possible message and scenario to catch every possible "slave could be NULL" case.

Jarod Wilson (7):
bonding: improve event debug usability
bonding: fix error messages in bond_do_fail_over_mac
bonding: add slave_foo printk macros bonding/main: convert to using slave printk macros bonding/802.3ad: convert to using slave printk macros bonding/alb: convert to using slave printk macros bonding/options: convert to using slave printk macros

 drivers/net/bonding/bond_3ad.c     | 222 +++++++++++----------
 drivers/net/bonding/bond_alb.c     |  30 +--
 drivers/net/bonding/bond_main.c    | 309 +++++++++++++----------------
 drivers/net/bonding/bond_options.c |  30 ++-
 include/net/bonding.h              |   9 +
 5 files changed, 293 insertions(+), 307 deletions(-)
Signature · 1 line
2.20.1