Skip to content

Add RX archtecture support

Philippe Mathieu-Daudé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v19 Latest21 patches 2 repliesIn review
  2. v1829 patches 9 repliesSuperseded

Patches in v19 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21target/rx: TCG translationtarget/rx/Makefile.objs target/rx/insns.decode target/rx/translate.c+3065 -00 replies
2/21target/rx: TCG helpertarget/rx/helper.c target/rx/helper.h target/rx/op_helper.c+649 -00 replies
3/21target/rx: CPU definitiontarget/rx/cpu-qom.h target/rx/cpu.c target/rx/cpu.h +2 more+645 -01 reply
4/21target/rx: RX disassemblerinclude/disas/dis-asm.h target/rx/disas.c+1485 -00 replies
5/21target/rx: Disassemble rx_index_addr into a stringtarget/rx/disas.c+55 -990 replies
6/21target/rx: Replace operand with prt_ldmi in disassemblertarget/rx/disas.c+27 -500 replies
7/21target/rx: Use prt_ldmi for XCHG_mr disassemblytarget/rx/disas.c+1 -70 replies
8/21target/rx: Emit all disassembly in one prt()target/rx/disas.c+39 -360 replies
9/21target/rx: Collect all bytes during disassemblytarget/rx/disas.c+42 -200 replies
10/21target/rx: Dump bytes for each insn during disassemblytarget/rx/disas.c+15 -10 replies
11/21hw/intc: RX62N interrupt controller (ICUa)hw/intc/Kconfig hw/intc/Makefile.objs hw/intc/rx_icu.c +1 more+436 -00 replies
12/21hw/timer: RX62N internal timer moduleshw/timer/Kconfig hw/timer/Makefile.objs hw/timer/renesas_cmt.c +3 more+830 -00 replies
13/21hw/char: RX62N serial communication interface (SCI)hw/char/Kconfig hw/char/Makefile.objs hw/char/renesas_sci.c +1 more+389 -00 replies
14/21hw/rx: RX Target hardware definitionhw/rx/Kconfig hw/rx/Makefile.objs hw/rx/rx-virt.c +3 more+457 -00 replies
15/21hw/rx: Honor -accel qtesthw/rx/rx62n.c+9 -10 replies
16/21hw/rx: Restrict the RX62N microcontroller to the RX62N CPU corehw/rx/rx-virt.c+8 -01 reply
17/21qemu/bitops.h: Add extract8 and extract16include/qemu/bitops.h+38 -00 replies
18/21hw/registerfields.h: Add 8bit and 16bit register macrosinclude/hw/registerfields.h+31 -10 replies
19/21Add rx-softmmuarch_init.c configure default-configs/rx-softmmu.mak +5 more+19 -10 replies
20/21MAINTAINERS: Add RXMAINTAINERS+19 -00 replies
21/21BootLinuxConsoleTest: Test the RX-Virt machinetests/acceptance/boot_linux_console.py+51 -00 replies

Reviews trailers per patch

20 of 21 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéAlex BennéeRichard HendersonYoshinori SatoAlistair Francis
1/21T-b T-b R-b
2/21T-b R-b
3/21R-b
4/21T-b R-b
5/21T-b R-b
6/21R-b T-b R-b
7/21R-b T-b R-b
8/21R-b T-b R-b
9/21R-b T-b R-b
10/21R-b T-b R-b
11/21R-b T-b R-b
12/21R-b T-b R-b
13/21R-b T-b R-b
14/21T-b R-b
15/21R-b T-b
16/21R-b
17/21R-b T-b R-b
18/21R-b T-b R-b R-b
19/21T-b R-b
20/21R-b R-b
21/21

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v19 thread

Cover letter [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support

Hi Yoshinori, Richard, Igor.

This series an iteration of the previous v16 from Yoshinori with the fixups requested by Igor here:
https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg07260.html
and
https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg01547.html
plus trivial cleanups.

It is based on commit 19735c837ae2056b4651720290eda59498eca65a, that is before the merge of pull-tcg-20190610 (CPUNegativeOffsetState) which resulted in commit a578cdfbdd8f9beff5ced52b7826ddb1669abbbf.

Series reordered, some patches squashed.

Patches modified: 2, 3, 14, 19 (wait review from Igor) New patch: 16 (wait review from Yoshinori) Extra patch: 21 (meant for testing)

This branch is available here: https://gitlab.com/philmd/qemu/tree/rx-v19

We have:

$ qemu-system-rx -cpu help
rx62n

(qemu) info qom-tree
/machine (rx-virt-machine)
/peripheral (container)
/mcu (rx62n)

    /sci[0] (renesas-sci)
      /renesas-sci[0] (qemu:memory-region)
    /icu (rx-icu)
      ...
    /cpu (rx62n-rx-cpu)
      /unnamed-gpio-in[0] (irq)
      /unnamed-gpio-in[1] (irq)
    ...
$ git backport-diff -u rx-16 -r 19735c837ae..rx-v19
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/21:[----] [--] 'target/rx: TCG translation'
002/21:[0011] [FC] 'target/rx: TCG helper'
003/21:[0136] [FC] 'target/rx: CPU definition'
004/21:[----] [--] 'target/rx: RX disassembler'
005/21:[----] [--] 'target/rx: Disassemble rx_index_addr into a string' 006/21:[----] [--] 'target/rx: Replace operand with prt_ldmi in disassembler' 007/21:[----] [--] 'target/rx: Use prt_ldmi for XCHG_mr disassembly' 008/21:[----] [--] 'target/rx: Emit all disassembly in one prt()' 009/21:[----] [--] 'target/rx: Collect all bytes during disassembly' 010/21:[----] [--] 'target/rx: Dump bytes for each insn during disassembly' 011/21:[----] [--] 'hw/intc: RX62N interrupt controller (ICUa)' 012/21:[----] [--] 'hw/timer: RX62N internal timer modules' 013/21:[----] [--] 'hw/char: RX62N serial communication interface (SCI)' 014/21:[0013] [FC] 'hw/rx: RX Target hardware definition' 015/21:[----] [-C] 'hw/rx: Honor -accel qtest'
016/21:[down] 'hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core' 017/21:[----] [--] 'qemu/bitops.h: Add extract8 and extract16' 018/21:[----] [--] 'hw/registerfields.h: Add 8bit and 16bit register macros' 019/21:[0005] [FC] 'Add rx-softmmu'
020/21:[----] [--] 'MAINTAINERS: Add RX'
021/21:[down] 'BootLinuxConsoleTest: Test the RX-Virt machine'

Thanks,

Phil.

Philippe Mathieu-Daudé (3):
hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core hw/registerfields.h: Add 8bit and 16bit register macros
BootLinuxConsoleTest: Test the RX-Virt machine

Richard Henderson (7):
target/rx: Disassemble rx_index_addr into a string target/rx: Replace operand with prt_ldmi in disassembler target/rx: Use prt_ldmi for XCHG_mr disassembly target/rx: Emit all disassembly in one prt() target/rx: Collect all bytes during disassembly target/rx: Dump bytes for each insn during disassembly hw/rx: Honor -accel qtest

Yoshinori Sato (11):
target/rx: TCG translation
target/rx: TCG helper
target/rx: CPU definition
target/rx: RX disassembler
hw/intc: RX62N interrupt controller (ICUa) hw/timer: RX62N internal timer modules hw/char: RX62N serial communication interface (SCI) hw/rx: RX Target hardware definition qemu/bitops.h: Add extract8 and extract16 Add rx-softmmu
MAINTAINERS: Add RX

 MAINTAINERS                            |   19 +
 arch_init.c                            |    2 +
 configure                              |    8 +
 default-configs/rx-softmmu.mak         |    3 +
 hw/Kconfig                             |    1 +
 hw/char/Kconfig                        |    3 +
 hw/char/Makefile.objs                  |    1 +
 hw/char/renesas_sci.c                  |  340 ++++
 hw/intc/Kconfig                        |    3 +
 hw/intc/Makefile.objs                  |    1 +
 hw/intc/rx_icu.c                       |  376 ++++
 hw/rx/Kconfig                          |   14 +
 hw/rx/Makefile.objs                    |    2 +
 hw/rx/rx-virt.c                        |  113 ++
 hw/rx/rx62n.c                          |  246 +++
 hw/timer/Kconfig                       |    6 +
 hw/timer/Makefile.objs                 |    3 +
 hw/timer/renesas_cmt.c                 |  275 +++
 hw/timer/renesas_tmr.c                 |  455 +++++
 include/disas/dis-asm.h                |    5 +
 include/exec/poison.h                  |    1 +
 include/hw/char/renesas_sci.h          |   45 +
 include/hw/intc/rx_icu.h               |   56 +
 include/hw/registerfields.h            |   32 +-
 include/hw/rx/rx.h                     |    7 +
 include/hw/rx/rx62n.h                  |   91 +
 include/hw/timer/renesas_cmt.h         |   38 +
 include/hw/timer/renesas_tmr.h         |   53 +
 include/qemu/bitops.h                  |   38 +
 include/sysemu/arch_init.h             |    1 +
 qapi/common.json                       |    3 +-
 target/rx/Makefile.objs                |   12 +
 target/rx/cpu-qom.h                    |   42 +
 target/rx/cpu.c                        |  252 +++
 target/rx/cpu.h                        |  201 ++
 target/rx/disas.c                      | 1446 ++++++++++++++
 target/rx/gdbstub.c                    |  112 ++
 target/rx/helper.c                     |  148 ++
 target/rx/helper.h                     |   31 +
 target/rx/insns.decode                 |  621 ++++++
 target/rx/monitor.c                    |   38 +
 target/rx/op_helper.c                  |  470 +++++
 target/rx/translate.c                  | 2432 ++++++++++++++++++++++++
 tests/acceptance/boot_linux_console.py |   51 +
 tests/machine-none-test.c              |    1 +
 45 files changed, 8096 insertions(+), 2 deletions(-)
 create mode 100644 default-configs/rx-softmmu.mak
 create mode 100644 hw/char/renesas_sci.c
 create mode 100644 hw/intc/rx_icu.c
 create mode 100644 hw/rx/Kconfig
 create mode 100644 hw/rx/Makefile.objs
 create mode 100644 hw/rx/rx-virt.c
 create mode 100644 hw/rx/rx62n.c
 create mode 100644 hw/timer/renesas_cmt.c
 create mode 100644 hw/timer/renesas_tmr.c
 create mode 100644 include/hw/char/renesas_sci.h
 create mode 100644 include/hw/intc/rx_icu.h
 create mode 100644 include/hw/rx/rx.h
 create mode 100644 include/hw/rx/rx62n.h
 create mode 100644 include/hw/timer/renesas_cmt.h
 create mode 100644 include/hw/timer/renesas_tmr.h
 create mode 100644 target/rx/Makefile.objs
 create mode 100644 target/rx/cpu-qom.h
 create mode 100644 target/rx/cpu.c
 create mode 100644 target/rx/cpu.h
 create mode 100644 target/rx/disas.c
 create mode 100644 target/rx/gdbstub.c
 create mode 100644 target/rx/helper.c
 create mode 100644 target/rx/helper.h
 create mode 100644 target/rx/insns.decode
 create mode 100644 target/rx/monitor.c
 create mode 100644 target/rx/op_helper.c
 create mode 100644 target/rx/translate.c
Signature · 1 line
2.20.1