Skip to content

fix qcow2_can_store_new_dirty_bitmap

Vladimir Sementsov-Ogievskiy qemu-devel 2 versions – Applied

Status from this message: Thanks, applied to my block-next branch:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 15 repliesApplied
  2. v11 patch 5 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2qcow2-bitmaps: fix qcow2_can_store_new_dirty_bitmapblock/qcow2-bitmap.c+18 -233 replies
2/2iotests: add 269 to check maximum of bitmaps in qcow2tests/qemu-iotests/269 tests/qemu-iotests/269.out tests/qemu-iotests/group+51 -02 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchMax Reitz
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

Hi all!

Here is a fix for persistent bitmaps managing: we must check existent but not yet stored bitmaps for qcow2-related constraints, like maximum number of bitmaps in qcow2 image.

v2:

01: change assertion to error-return at function start
Be free to add

if it's appropriate
02: new test
Ohh, it takes about 4 minutes. Be free to drop it, as I doubt that it worth to have. The case is simple, we may live without a test.

Vladimir Sementsov-Ogievskiy (2):
qcow2-bitmaps: fix qcow2_can_store_new_dirty_bitmap
iotests: add 269 to check maximum of bitmaps in qcow2

 block/qcow2-bitmap.c       | 41 +++++++++++++++------------------
 tests/qemu-iotests/269     | 47 ++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/269.out |  3 +++
 tests/qemu-iotests/group   |  1 +
 4 files changed, 69 insertions(+), 23 deletions(-)
 create mode 100755 tests/qemu-iotests/269
 create mode 100644 tests/qemu-iotests/269.out
Signature · 1 line
2.21.0