Skip to content

kni: fixes and cleanups

Stephen Hemminger dpdk-dev 7 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest9 patches 2 repliesApplied
  2. v59 patches 2 repliesSuperseded
  3. v48 patches 0 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v3 posting 2/28 patches0 repliesSuperseded
v3 posting 1/28 patches0 repliesSuperseded
v27 patches4 repliesSuperseded
v19 patches1 replySuperseded

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/9kni: don't need stubs for rx_mode or ioctlkernel/linux/kni/kni_net.c+0 -190 replies
2/9kni: use netdev_alloc_skbkernel/linux/kni/kni_net.c+3 -140 replies
3/9kni: don't keep stats in kni_netkernel/linux/kni/kni_dev.h kernel/linux/kni/kni_net.c+15 -290 replies
4/9kni: drop unused fieldskernel/linux/kni/kni_dev.h kernel/linux/kni/kni_misc.c+0 -60 replies
5/9kni: use proper type for kni fifo'skernel/linux/kni/kni_dev.h+6 -60 replies
6/9kni: return -EFAULT if copy_from_user failskernel/linux/kni/kni_misc.c+5 -110 replies
7/9kni: fix style issueskernel/linux/kni/kni_net.c lib/librte_kni/rte_kni.c+23 -220 replies
8/9kni: add minimal ethtoolkernel/linux/kni/kni_dev.h kernel/linux/kni/kni_misc.c kernel/linux/kni/kni_net.c+17 -00 replies
9/9doc: update KNI documentationdoc/guides/prog_guide/kernel_nic_interface.rst doc/guides/sample_app_ug/kernel_nic_interface.rst+20 -130 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchFerruh Yigit
SeriesA-b
1/9
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [dpdk-dev] [PATCH v6 0/9] kni: fixes and cleanups

While testing KNI with netvsc, saw lots of places more code could be safely removed from KNI kernel driver.

v6 - more updates to documentation
v5 - add minimal ethtool, fix checkpath author complaints v4 - add more style fixes
v3 - rebase to current master, add style fix patch
v2 - get rid of unnecessary padding, combine the unused field patches

Stephen Hemminger (9):
kni: don't need stubs for rx_mode or ioctl
kni: use netdev_alloc_skb
kni: don't keep stats in kni_net
kni: drop unused fields
kni: use proper type for kni fifo's
kni: return -EFAULT if copy_from_user fails
kni: fix style issues
kni: add minimal ethtool
doc: update KNI documentation

 .../prog_guide/kernel_nic_interface.rst       |   9 +-
 .../sample_app_ug/kernel_nic_interface.rst    |  24 +++--
 kernel/linux/kni/kni_dev.h                    |  20 ++--
 kernel/linux/kni/kni_misc.c                   |  18 ++--
 kernel/linux/kni/kni_net.c                    | 100 +++++++-----------
 lib/librte_kni/rte_kni.c                      |  38 +++----
 6 files changed, 89 insertions(+), 120 deletions(-)
Signature · 1 line
2.20.1