Skip to content

Few more cleanups for tegra-timer

Dmitry Osipenko linux-tegra lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 14 repliesIn review
  2. v26 patches 13 repliesSuperseded
  3. v13 patches 2 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8clocksource/drivers/tegra: Restore timer rate on Tegra210drivers/clocksource/timer-tegra.c+2 -01 reply
2/8clocksource/drivers/tegra: Remove duplicated use of per_cpu_ptrdrivers/clocksource/timer-tegra.c+25 -171 reply
3/8clocksource/drivers/tegra: Set and use timer's perioddrivers/clocksource/timer-tegra.c+3 -23 replies
4/8clocksource/drivers/tegra: Drop unneeded typecasting in one placedrivers/clocksource/timer-tegra.c+1 -11 reply
5/8clocksource/drivers/tegra: Add verbose definition for 1MHz constantdrivers/clocksource/timer-tegra.c+7 -51 reply
6/8clocksource/drivers/tegra: Restore base address before cleanupdrivers/clocksource/timer-tegra.c+2 -02 replies
7/8clocksource/drivers/tegra: Cycles can't be 0drivers/clocksource/timer-tegra.c+10 -33 replies
8/8clocksource/drivers/tegra: Set up maximum-ticks limit properlydrivers/clocksource/timer-tegra.c+9 -12 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchJon HunterThierry Reding
1/8A-b T-b A-b
2/8A-b A-b
3/8A-b A-b
4/8A-b A-b
5/8A-b A-b
6/8A-b A-b
7/8A-b A-b
8/8A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/8] Few more cleanups for tegra-timer

Hello,

This a followup to [0] that includes some more fixes and further prettifies the driver's code.

[0] https://patchwork.ozlabs.org/project/linux-tegra/list/?series=111529

Changelog:

v3: Addressed request from Jon Hunter that was made in a review comment
to v2 by dropping the timer's period rounding-up in the "Set and use timer' period" patch.

Appended two new patches to this series that were already sent out and reviewed after the v2 of this series:

clocksource/drivers/tegra: Cycles can't be 0 clocksource/drivers/tegra: Set up maximum-ticks limit properly

In this two new patches I addressed review comments that were made by Thierry Reding by adding clarifying comments to the code and extending the commit messages a tad.

Corrected the "Fixes" tag in a "Restore timer rate on Tegra210" patch such that linux-next checker won't complain about the shortened commit's subject.

v2: Fixed a bug that was introduced by [0] in a newly added patch:
"Restore timer rate on Tegra210".

Fixed potential problem in regards to error handling in another new
patch: "Restore base address before cleanup".

Added new patch "Add verbose definition for 1MHz constant" as per Daniel's Lezcano recommendation.

Fixed a code typo that was made in "Remove duplicated use of per_cpu_ptr" of v1.

Dmitry Osipenko (8):
clocksource/drivers/tegra: Restore timer rate on Tegra210 clocksource/drivers/tegra: Remove duplicated use of per_cpu_ptr clocksource/drivers/tegra: Set and use timer's period clocksource/drivers/tegra: Drop unneeded typecasting in one place clocksource/drivers/tegra: Add verbose definition for 1MHz constant clocksource/drivers/tegra: Restore base address before cleanup clocksource/drivers/tegra: Cycles can't be 0 clocksource/drivers/tegra: Set up maximum-ticks limit properly

 drivers/clocksource/timer-tegra.c | 82 +++++++++++++++++++++----------
 1 file changed, 56 insertions(+), 26 deletions(-)
Signature · 1 line
2.22.0