Skip to content

bcache: two emergent fixes for Linux v5.2-rc5

Coly Li linux-bcache linux-block stable 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2bcache: fix stack corruption by PRECEDING_KEY()drivers/md/bcache/bset.c drivers/md/bcache/bset.h+33 -170 replies
2/2bcache: only set BCACHE_DEV_WB_RUNNING when cached device attacheddrivers/md/bcache/sysfs.c+6 -10 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRolf FokkensPierre JUHENShenghui WangBjørn Forsman
1/2R-b R-b T-b T-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/2] bcache: two emergent fixes for Linux v5.2-rc5

Hi Jens,

Here are two emergent fixes that we should have in Linux v5.2-rc5.

- bcache: fix stack corruption by PRECEDING_KEY()
This patch fixes a GCC9 compiled bcache panic problem, which is reported by Fedora Core, Arch Linux and SUSE Leap Linux users whose kernels are combiled with GCC9. This bug hides for long time since v4.13 and triggered by the new GCC9.
When people upgrade their kernel to a GCC9 compiled kernel, this bug may cause the metadata corruption. So we should have this fix in upstream ASAP.

- bcache: only set BCACHE_DEV_WB_RUNNING when cached device attached There are 2 users report bcache panic after changing writeback percentage of an non-attached bcache device. Therefore I suggest to have this fix upstream in this run.

Thank you in advance for taking care of these two fixes.

Coly Li
---
Coly Li (2):
bcache: fix stack corruption by PRECEDING_KEY()
bcache: only set BCACHE_DEV_WB_RUNNING when cached device attached

 drivers/md/bcache/bset.c  | 16 +++++++++++++---
 drivers/md/bcache/bset.h  | 34 ++++++++++++++++++++--------------
 drivers/md/bcache/sysfs.c |  7 ++++++-
 3 files changed, 39 insertions(+), 18 deletions(-)
Signature · 1 line
2.16.4