Skip to content

RK3288 VP8 decoding support

Ezequiel Garcia linux-media linux-rockchip lkml 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 0 repliesNew
  2. v34 patches 1 replySuperseded
  3. v22 patches 13 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches4 repliesSuperseded

Changes in v4 from the cover letter

* Zero padding fields, and document this as a specification.
* Minor cosmetic changes.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4media: v4l2-ctrl: Move compound control validationdrivers/media/v4l2-core/v4l2-ctrls.c+69 -570 replies
2/4media: uapi: Add VP8 stateless decoder APIDocumentation/media/uapi/v4l/biblio.rst Documentation/media/uapi/v4l/ext-ctrls-codec.rst Documentation/media/uapi/v4l/pixfmt-compressed.rst +4 more+477 -00 replies
3/4media: v4l2-ctrl: Validate VP8 stateless decoder controlsdrivers/media/v4l2-core/v4l2-ctrls.c+21 -00 replies
4/4media: hantro: Add support for VP8 decoding on rk3288drivers/staging/media/hantro/Makefile drivers/staging/media/hantro/hantro.h drivers/staging/media/hantro/hantro_drv.c +5 more+789 -20 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchTomasz FigaBoris BrezillonNicolas Dufresne
1/4
2/4R-b R-b R-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/4] RK3288 VP8 decoding support

This patchset adds support for Hantro G1 VP8 stateless decoding, as available on RK3288 SoC.

In order to support VP8 stateless decoding, a new pixel format is introduced V4L2_PIX_FMT_VP8_FRAME, to be used with a new control V4L2_CID_MPEG_VIDEO_VP8_FRAME_HEADER.

Changes in v4:

* Zero padding fields, and document this as a specification.
* Minor cosmetic changes.

Changes in v3:

* Validate num_dct_parts field, as suggested by Philipp. This fixes the kernel oops reported by Philipp.
* Add documentation for num_dct_parts constraint.
* Renamed macroblock_bit_offset to first_part_header_bits and fixed its documentation.

Changes in v2:

* Verified that all the fields in the uAPI come from the spec [1].
* Structures and fields have 8-bytes alignment and sizes, as suggested by Boris.
* Moved 1-bit fields to a bit in the appropriate flags fields.
* Dropped dequant_factors[4][3][2], I really couldn't find this field or anything similar in the spec. It's not mentioned anywhere in Chromium or FFMPEG, so I decided to drop it.

[1] https://www.rfc-editor.org/rfc/rfc6386.html

Ezequiel Garcia (2):
media: v4l2-ctrl: Move compound control validation
media: v4l2-ctrl: Validate VP8 stateless decoder controls

Pawel Osciak (1):
media: uapi: Add VP8 stateless decoder API

ZhiChao Yu (1):
media: hantro: Add support for VP8 decoding on rk3288

 Documentation/media/uapi/v4l/biblio.rst       |  10 +
 .../media/uapi/v4l/ext-ctrls-codec.rst        | 323 +++++++++++
 .../media/uapi/v4l/pixfmt-compressed.rst      |  20 +
 drivers/media/v4l2-core/v4l2-ctrls.c          | 157 ++++--
 drivers/media/v4l2-core/v4l2-ioctl.c          |   1 +
 drivers/staging/media/hantro/Makefile         |   4 +-
 drivers/staging/media/hantro/hantro.h         |  27 +
 drivers/staging/media/hantro/hantro_drv.c     |   6 +
 .../staging/media/hantro/hantro_g1_vp8_dec.c  | 526 ++++++++++++++++++
 drivers/staging/media/hantro/hantro_hw.h      |  17 +
 drivers/staging/media/hantro/hantro_v4l2.c    |   1 +
 drivers/staging/media/hantro/hantro_vp8.c     | 188 +++++++
 drivers/staging/media/hantro/rk3288_vpu_hw.c  |  22 +-
 include/media/v4l2-ctrls.h                    |   3 +
 include/media/vp8-ctrls.h                     | 110 ++++
 15 files changed, 1356 insertions(+), 59 deletions(-)
 create mode 100644 drivers/staging/media/hantro/hantro_g1_vp8_dec.c
 create mode 100644 drivers/staging/media/hantro/hantro_vp8.c
 create mode 100644 include/media/vp8-ctrls.h
Signature · 1 line
2.20.1