Skip to content

Resolve if/else brace-style errors

Shobhit Kukreti lkml 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 0 repliesNew
  2. v33 patches 1 replySuperseded
  3. v21 patch 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch1 replySuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driverdrivers/staging/rtl8723bs/os_dep/mlme_linux.c drivers/staging/rtl8723bs/os_dep/recv_linux.c drivers/staging/rtl8723bs/os_dep/rtw_proc.c +2 more+47 -880 replies
2/3staging: rtl8723bs: Resolve the checkpatch error: else should follow close brace '}'drivers/staging/rtl8723bs/os_dep/mlme_linux.c drivers/staging/rtl8723bs/os_dep/recv_linux.c drivers/staging/rtl8723bs/os_dep/sdio_intf.c+12 -240 replies
3/3staging: rtl8723bs: Fix Indentation Error: code indent should use tabs where possibledrivers/staging/rtl8723bs/os_dep/recv_linux.c drivers/staging/rtl8723bs/os_dep/sdio_intf.c+21 -210 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/3] Resolve if/else brace-style errors

This patchset fixes the following errors reported by checkpatch in the staging/rtl8723bs driver.

Patch[1/3]: Fix check patch error "that open brace { should be on the previous line"

Patch[2/3]: Fix the error else should follow close brace '}'

Patch[3/3]: Fix Indentation Error

The patch should be applied in the sequence of 1-3. Each patch performs one clean up operation.

version 4 changes:
- Moved comments to a new line
- Removed an extra blank line

version 3 changes:
- Converted the patch to a patchset
- Resolve checkpatch errors:
else should follow close brace '}' Fixed Indentation Error to use tabs
- Compiles and builds, untested on real hardware.

version 2 changes:
- Removed Trailing whitespace introduced in the previous patch
- Moved comments to a new line in the else statement

Shobhit Kukreti (3):
staging: rtl8723bs: Resolve checkpatch error "that open brace { should
be on the previous line" in the rtl8723 driver
staging: rtl8723bs: Resolve the checkpatch error: else should follow
close brace '}'
staging: rtl8723bs: Fix Indentation Error: code indent should use tabs
where possible

 drivers/staging/rtl8723bs/os_dep/mlme_linux.c     | 18 ++---
 drivers/staging/rtl8723bs/os_dep/recv_linux.c     | 89 ++++++++---------------
 drivers/staging/rtl8723bs/os_dep/rtw_proc.c       |  6 +-
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c      | 54 ++++++--------
 drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c | 24 ++----
 5 files changed, 69 insertions(+), 122 deletions(-)
Signature · 1 line
2.7.4