Skip to content

configure: Fix softmmu --static linking

Philippe Mathieu-Daudé qemu-devel qemu-trivial 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 4 repliesIn review
  2. v16 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- pkg-config already use the '--static' argument, do not add it twice
- Fixed x86_64 host builds (was missing GTK and OpenGL patches)
- Added Niels R-b tag on the first patch
- The Travis-CI job now succeeds:
https://travis-ci.org/philmd/qemu/jobs/545653697 (6 min 7 sec)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9configure: Only generate GLUSTERFS variables if glusterfs is usableconfigure+18 -181 reply
2/9configure: Link test before auto-enabling GlusterFS librariesconfigure+11 -10 replies
3/9configure: Link test before auto-enabling libusb libraryconfigure+11 -10 replies
4/9configure: Link test before auto-enabling libusbredir libraryconfigure+11 -10 replies
5/9configure: Link test before auto-enabling PulseAudio libraryconfigure+15 -40 replies
6/9configure: Link test before auto-enabling OpenGL librariesconfigure+14 -40 replies
7/9configure: Link test before auto-enabling GTK librariesconfigure+11 -10 replies
8/9tests/docker: Kludge for missing libunistring.so symlink on Ubuntu 18.04tests/docker/dockerfiles/ubuntu1804.docker+4 -00 replies
9/9.travis.yml: Test softmmu static linking.travis.yml+5 -00 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchNiels de VosDaniel P. Berrangé
1/9R-b R-b
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/9] configure: Fix softmmu --static linking

Hi,

Apparently QEMU static linking is slowly bitroting. Obviously it depends the libraries an user has installed, anyway it seems there are not much testing done.

This series fixes few issues, enough to build QEMU on a Ubuntu 18.04 host.

Peter commented on v1:

The main reason for supporting static linking is so we can build the user-mode emulators. Almost always the problems with static linking the softmmu binaries and the tools are issues with the distro's packaging of the static libraries (pkg-config files which specify things that don't work for static is a common one).

So we could put in a lot of checking of "is what pkg-config tells us broken". Or we could just say "we don't support static linking for anything except the usermode binaries". We should probably phase in deprecation of that because it's possible somebody's using it seriously, but it seems like a fairly weird thing to do to me.

I share his view on this (restricting static linking to qemu-user) but since the work was already done when I read his comment, I still send the v2.

Since v1:
- pkg-config already use the '--static' argument, do not add it twice
- Fixed x86_64 host builds (was missing GTK and OpenGL patches)
- Added Niels R-b tag on the first patch
- The Travis-CI job now succeeds:
https://travis-ci.org/philmd/qemu/jobs/545653697 (6 min 7 sec)

Regards,

Phil.

Philippe Mathieu-Daudé (9):
configure: Only generate GLUSTERFS variables if glusterfs is usable
configure: Link test before auto-enabling GlusterFS libraries
configure: Link test before auto-enabling libusb library
configure: Link test before auto-enabling libusbredir library
configure: Link test before auto-enabling PulseAudio library
configure: Link test before auto-enabling OpenGL libraries
configure: Link test before auto-enabling GTK libraries tests/docker: Kludge for missing libunistring.so symlink on Ubuntu

    18.04

.travis.yml: Test softmmu static linking

 .travis.yml                                |   5 +
 configure                                  | 121 ++++++++++++++++-----
 tests/docker/dockerfiles/ubuntu1804.docker |   4 +
 3 files changed, 100 insertions(+), 30 deletions(-)
Signature · 1 line
2.20.1