Skip to content

compat/obstack: update from upstream

SZEDER Gábor git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4compat/obstack: update from upstreamcompat/obstack.c compat/obstack.h+606 -6280 replies
2/4SQUASH??? compat/obstack: fix portability issuescompat/obstack.c+4 -250 replies
3/4SQUASH??? compat/obstack: fix build errors with Clangcompat/obstack.c compat/obstack.h+4 -50 replies
4/4compat/obstack: fix some sparse warningscompat/obstack.c+7 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC/PATCH v1 0/4] compat/obstack: update from upstream

Update 'compat/obstack.{c,h}' from upstream, because they already use 'size_t' instead of 'long' in places that might eventually end up as an argument to malloc(), which might solve build errors with GCC 8 on Windows.

The first patch just imports from upstream and doesn't modify anything at all, and, consequently, it can't be compiled because of a screenful or two of errors. This is bad for future bisects, of course.

OTOH, adding all the necessary build fixes right away makes review harder...

I'm not sure how to deal with this situation, so here is a series with the fixes in separate patches for review, for now. If there's an agreement that this is the direction to take, then I'll squash in the fixes in the first patch and touch up the resulting commit message.

Ramsay, could you please run sparse on top of these patch series to make sure that I caught and converted all "0 instead of NULL" usages in the last patch? Thanks.

And here is an all-green build of these patches on Travis CI:

https://travis-ci.org/szeder/git/builds/545645247

(and one bonus patch on top to deal with some Homebrew nonsense)

SZEDER Gábor (4):
compat/obstack: update from upstream SQUASH??? compat/obstack: fix portability issues SQUASH??? compat/obstack: fix build errors with Clang compat/obstack: fix some sparse warnings

 compat/obstack.c | 356 ++++++++------------
 compat/obstack.h | 832 ++++++++++++++++++++++++-----------------------
 2 files changed, 572 insertions(+), 616 deletions(-)
Signature · 1 line
2.22.0.589.g5bd7971b91