Skip to content

drm/virtio: switch from ttm to gem shmem helpers.

Gerd Hoffmann dri-devel lkml virtualization 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest18 patches 2 repliesIn review
  2. v818 patches 5 repliesSuperseded
  3. v718 patches 0 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v618 patches48 repliesSuperseded
v512 patches6 repliesSuperseded
v412 patches17 repliesSuperseded
v312 patches13 repliesSuperseded
v212 patches9 repliesSuperseded
v14 patches11 repliesSuperseded

Changes in v9 from the cover letter

- rebase to latest dem-misc-next, adapt to changes.
- fix issues found by Chia-I Wu.

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18drm/virtio: pass gem reservation object to ttm initdrivers/gpu/drm/virtio/virtgpu_object.c+2 -10 replies
1/18drm/virtio: pass gem reservation object to ttm initdrivers/gpu/drm/virtio/virtgpu_object.c+2 -10 replies
2/18drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.drivers/gpu/drm/virtio/virtgpu_ioctl.c+16 -120 replies
2/18drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.drivers/gpu/drm/virtio/virtgpu_ioctl.c+16 -120 replies
3/18drm/virtio: simplify cursor updatesdrivers/gpu/drm/virtio/virtgpu_plane.c+3 -100 replies
4/18drm/virtio: remove virtio_gpu_object_waitdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_object.c+0 -140 replies
4/18drm/virtio: remove virtio_gpu_object_waitdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_object.c+0 -140 replies
5/18drm/virtio: drop no_wait argument from virtio_gpu_object_reservedrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_gem.c drivers/gpu/drm/virtio/virtgpu_ioctl.c+6 -70 replies
5/18drm/virtio: drop no_wait argument from virtio_gpu_object_reservedrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_gem.c drivers/gpu/drm/virtio/virtgpu_ioctl.c+6 -70 replies
6/18drm/virtio: remove ttm calls from in virtio_gpu_object_{reserve,unreserve}drivers/gpu/drm/virtio/virtgpu_drv.h+3 -30 replies
6/18drm/virtio: remove ttm calls from in virtio_gpu_object_{reserve, unreserve}drivers/gpu/drm/virtio/virtgpu_drv.h+3 -30 replies
7/18drm/virtio: add virtio_gpu_object_array & helpersdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_gem.c+110 -00 replies
7/18drm/virtio: add virtio_gpu_object_array & helpersdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_gem.c+110 -00 replies
8/18drm/virtio: rework virtio_gpu_execbuffer_ioctl fencingdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_ioctl.c drivers/gpu/drm/virtio/virtgpu_vq.c+38 -450 replies
8/18drm/virtio: rework virtio_gpu_execbuffer_ioctl fencingdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_ioctl.c drivers/gpu/drm/virtio/virtgpu_vq.c+38 -450 replies
9/18drm/virtio: rework virtio_gpu_object_create fencingdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_object.c drivers/gpu/drm/virtio/virtgpu_vq.c+37 -430 replies
9/18drm/virtio: rework virtio_gpu_object_create fencingdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_object.c drivers/gpu/drm/virtio/virtgpu_vq.c+37 -430 replies
10/18drm/virtio: rework virtio_gpu_transfer_from_host_ioctl fencingdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_ioctl.c drivers/gpu/drm/virtio/virtgpu_vq.c+23 -280 replies
10/18drm/virtio: rework virtio_gpu_transfer_from_host_ioctl fencingdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_ioctl.c drivers/gpu/drm/virtio/virtgpu_vq.c+23 -280 replies
11/18drm/virtio: rework virtio_gpu_transfer_to_host_ioctl fencingdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_ioctl.c drivers/gpu/drm/virtio/virtgpu_plane.c +1 more+47 -370 replies
11/18drm/virtio: rework virtio_gpu_transfer_to_host_ioctl fencingdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_ioctl.c drivers/gpu/drm/virtio/virtgpu_plane.c +1 more+47 -370 replies
12/18drm/virtio: rework virtio_gpu_cmd_context_{attach,detach}_resourcedrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_gem.c drivers/gpu/drm/virtio/virtgpu_vq.c+21 -190 replies
12/18drm/virtio: rework virtio_gpu_cmd_context_{attach, detach}_resourcedrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_gem.c drivers/gpu/drm/virtio/virtgpu_vq.c+21 -190 replies
13/18drm/virtio: drop virtio_gpu_object_list_validate/virtio_gpu_unref_listdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_ioctl.c+0 -420 replies
13/18drm/virtio: drop virtio_gpu_object_list_validate/virtio_gpu_unref_listdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_ioctl.c+0 -420 replies
14/18drm/virtio: switch from ttm to gem shmem helpersdrivers/gpu/drm/virtio/Kconfig drivers/gpu/drm/virtio/Makefile drivers/gpu/drm/virtio/virtgpu_drv.c +8 more+80 -5350 replies
14/18drm/virtio: switch from ttm to gem shmem helpersdrivers/gpu/drm/virtio/Kconfig drivers/gpu/drm/virtio/Makefile drivers/gpu/drm/virtio/virtgpu_drv.c +8 more+80 -5350 replies
15/18drm/virtio: remove virtio_gpu_alloc_objectdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_gem.c drivers/gpu/drm/virtio/virtgpu_ioctl.c+7 -260 replies
15/18drm/virtio: remove virtio_gpu_alloc_objectdrivers/gpu/drm/virtio/virtgpu_drv.h drivers/gpu/drm/virtio/virtgpu_gem.c drivers/gpu/drm/virtio/virtgpu_ioctl.c+7 -260 replies
16/18drm/virtio: drop virtio_gpu_object_{ref,unref}drivers/gpu/drm/virtio/virtgpu_drv.h+0 -150 replies
16/18drm/virtio: drop virtio_gpu_object_{ref,unref}drivers/gpu/drm/virtio/virtgpu_drv.h+0 -150 replies
17/18drm/virtio: drop virtio_gpu_object_{reserve,unreserve}drivers/gpu/drm/virtio/virtgpu_drv.h+0 -210 replies
17/18drm/virtio: drop virtio_gpu_object_{reserve, unreserve}drivers/gpu/drm/virtio/virtgpu_drv.h+0 -210 replies
18/18drm/virtio: add fence sanity checkdrivers/gpu/drm/virtio/virtgpu_fence.c+4 -00 replies
18/18drm/virtio: add fence sanity checkdrivers/gpu/drm/virtio/virtgpu_fence.c+4 -00 replies

Reviews trailers per patch

17 of 35 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDaniel VetterChia-I Wu
SeriesR-b
1/18R-b R-b
1/18R-b R-b
2/18R-b R-b
2/18R-b R-b
3/18R-b
4/18R-b R-b
4/18R-b R-b
5/18R-b R-b
5/18R-b R-b
6/18R-b R-b
6/18R-b R-b
7/18
7/18
8/18
8/18
9/18
9/18
10/18
10/18
11/18
11/18
12/18
12/18
13/18A-b A-b
13/18A-b A-b
14/18A-b A-b
14/18A-b A-b
15/18A-b A-b
15/18A-b A-b
16/18
16/18
17/18
17/18
18/18
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH v9 00/18] drm/virtio: switch from ttm to gem shmem helpers.

ttm increasingly gets into the way while hacking on virtio-gpu memory management. It also overkill for what virtio-gpu needs. Lets get rid of it.

v9:
- rebase to latest dem-misc-next, adapt to changes.
- fix issues found by Chia-I Wu.
v8:
- rebase to latest drm-misc-next, adapt to changes.
v7:
- rebase to latest drm-misc-next
- reorder patches: switch all virtio commands to object array helpers first. then drop ttm, to make sure we don't release objects still in use.
- misc fixes.
v6:
- largely rewrite fencing logic, using the virtio_gpu_array_* helpers
- add more patches to the series.
v5:
- fence bugfixes.
- minor optimizations.
v4:
- make gem array helpers private to virtio.
- misc minor fixes.
v3:
- add gem array helpers.
- rework fencing.

please review.

thanks,
Gerd

Gerd Hoffmann (18):
drm/virtio: pass gem reservation object to ttm init drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper. drm/virtio: simplify cursor updates
drm/virtio: remove virtio_gpu_object_wait
drm/virtio: drop no_wait argument from virtio_gpu_object_reserve drm/virtio: remove ttm calls from in

    virtio_gpu_object_{reserve,unreserve}

drm/virtio: add virtio_gpu_object_array & helpers drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing drm/virtio: rework virtio_gpu_object_create fencing drm/virtio: rework virtio_gpu_transfer_from_host_ioctl fencing drm/virtio: rework virtio_gpu_transfer_to_host_ioctl fencing drm/virtio: rework virtio_gpu_cmd_context_{attach,detach}_resource drm/virtio: drop virtio_gpu_object_list_validate/virtio_gpu_unref_list drm/virtio: switch from ttm to gem shmem helpers drm/virtio: remove virtio_gpu_alloc_object
drm/virtio: drop virtio_gpu_object_{ref,unref}
drm/virtio: drop virtio_gpu_object_{reserve,unreserve} drm/virtio: add fence sanity check

 drivers/gpu/drm/virtio/virtgpu_drv.h    | 123 +++-------
 drivers/gpu/drm/virtio/virtgpu_drv.c    |  20 +-
 drivers/gpu/drm/virtio/virtgpu_fence.c  |   4 +
 drivers/gpu/drm/virtio/virtgpu_gem.c    | 156 ++++++++----
 drivers/gpu/drm/virtio/virtgpu_ioctl.c  | 224 ++++++-----------
 drivers/gpu/drm/virtio/virtgpu_kms.c    |   9 -
 drivers/gpu/drm/virtio/virtgpu_object.c | 222 ++++++-----------
 drivers/gpu/drm/virtio/virtgpu_plane.c  |  34 +--
 drivers/gpu/drm/virtio/virtgpu_prime.c  |  34 ---
 drivers/gpu/drm/virtio/virtgpu_ttm.c    | 305 ------------------------
 drivers/gpu/drm/virtio/virtgpu_vq.c     |  78 ++++--
 drivers/gpu/drm/virtio/Kconfig          |   2 +-
 drivers/gpu/drm/virtio/Makefile         |   2 +-
 13 files changed, 376 insertions(+), 837 deletions(-)
 delete mode 100644 drivers/gpu/drm/virtio/virtgpu_ttm.c
Signature · 6 lines
2.18.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel