Skip to content

tcp: make sack processing more robust

Eric Dumazet netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 27 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4tcp: limit payload size of sacked skbsinclude/linux/tcp.h include/net/tcp.h net/ipv4/tcp.c +2 more+30 -91 reply
2/4tcp: tcp_fragment() should apply sane memory limitsinclude/uapi/linux/snmp.h net/ipv4/proc.c net/ipv4/tcp_output.c+7 -021 replies
3/4tcp: add tcp_min_snd_mss sysctlDocumentation/networking/ip-sysctl.txt include/net/netns/ipv4.h net/ipv4/sysctl_net_ipv4.c +2 more+22 -22 replies
4/4tcp: enforce tcp_min_snd_mss in tcp_mtu_probing()net/ipv4/tcp_timer.c+1 -02 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchNeal CardwellTyler HicksYuchung ChengJonathan Lemon
1/4A-b R-b A-b
2/4A-b R-b A-b A-b
3/4A-b A-b A-b
4/4A-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH net 0/4] tcp: make sack processing more robust

Jonathan Looney brought to our attention multiple problems in TCP stack at the sender side.

SACK processing can be abused by malicious peers to either cause overflows, or increase of memory usage.

First two patches fix the immediate problems.

Since the malicious peers abuse senders by advertizing a very small MSS in their SYN or SYNACK packet, the last two patches add a new sysctl so that admins can chose a higher limit for MSS clamping.

Eric Dumazet (4):
tcp: limit payload size of sacked skbs
tcp: tcp_fragment() should apply sane memory limits
tcp: add tcp_min_snd_mss sysctl
tcp: enforce tcp_min_snd_mss in tcp_mtu_probing()

 Documentation/networking/ip-sysctl.txt |  8 ++++++++
 include/linux/tcp.h                    |  4 ++++
 include/net/netns/ipv4.h               |  1 +
 include/net/tcp.h                      |  2 ++
 include/uapi/linux/snmp.h              |  1 +
 net/ipv4/proc.c                        |  1 +
 net/ipv4/sysctl_net_ipv4.c             | 11 +++++++++++
 net/ipv4/tcp.c                         |  1 +
 net/ipv4/tcp_input.c                   | 26 ++++++++++++++++++++------
 net/ipv4/tcp_ipv4.c                    |  1 +
 net/ipv4/tcp_output.c                  | 10 +++++++---
 net/ipv4/tcp_timer.c                   |  1 +
 12 files changed, 58 insertions(+), 9 deletions(-)
Signature · 1 line
2.22.0.410.gd8fdbe21b5-goog