Skip to content

kernel-shark: Make some top level "make" changes and documention updates

Steven Rostedt linux-trace-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v12 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- Added a patch to first change the README to the latest make process

- Incorporated Yordan's suggestions about breaking up the build documentation into two sections, one explaining the "simple" method from the toplevel git repo, and the other explaining the "expert" method using cmake directly.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3kernelshark: Update the README for changes to the make processkernel-shark/README+40 -100 replies
2/3kernel-shark: Have "make clean" run cmake-clean.shMakefile kernel-shark/README+2 -10 replies
3/3kernel-shark: Add make BUILD_TYPE=X gui to change how the gui is madeMakefile kernel-shark/CMakeLists.txt kernel-shark/README+17 -31 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchYordan Karadzhov
1/3
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] kernel-shark: Make some top level "make" changes and documention updates

This is built on top of the three patches from Yordan that can be found here:

https://patchwork.kernel.org/project/linux-trace-devel/list/?series=132531

It makes "make clean" remove cmake generated files (my build failed and I couldn't figure out why. "make clean" should allow builds to build again when CMake files change).

I also adde a "make BUILD_TYPE=foo" to pass to the cmake command to change the CMAKE_BUILD_TYPE to allow an easy build by the package maintainers to change how KernelShark is built.

It also updates the README with the current way to build KernelShark.

Changes from v1:

- Added a patch to first change the README to the latest make process

- Incorporated Yordan's suggestions about breaking up the build documentation into two sections, one explaining the "simple" method from the toplevel git repo, and the other explaining the "expert" method using cmake directly.

Steven Rostedt (VMware) (3):
kernelshark: Update the README for changes to the make process
kernel-shark: Have "make clean" run cmake-clean.sh
kernel-shark: Add 'make BUILD_TYPE=X gui' to change how the gui is made

----

 Makefile                    |  6 ++++-
 kernel-shark/CMakeLists.txt |  2 +-
 kernel-shark/README         | 63 +++++++++++++++++++++++++++++++++++++--------
 3 files changed, 58 insertions(+), 13 deletions(-)