Skip to content

RFC MIPS: fix code relocation routine

Antony Pavlov barebox 1 version Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2MIPS: lib/Makefile: fix whitespacesarch/mips/lib/Makefile+2 -20 replies
2/2MIPS: relocate_code: fix barebox image memcpy() sizearch/mips/lib/reloc.c+5 -61 reply

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchOleksij Rempel
1/2
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 0/2] MIPS: fix code relocation routine

At the moment MIPS relocation code routine has at least two problems:

1. the first problem is fixed in the 'MIPS: relocate_code: fix barebox image size' patch from this patchseries.

2. relocate_code() calls flush_cache_all().
flush_cache_all() uses 'struct cpuinfo_mips current_cpu_data' data fields. These data fields are initialized in r4k_cache_init().

However in the current implementation the r4k_cache_init() function is called __AFTER__ relocate_code().

This cache problem can't be discovered via qemu.

Antony Pavlov (2):
MIPS: lib/Makefile: fix whitespaces
MIPS: relocate_code: fix barebox image memcpy() size

 arch/mips/lib/Makefile |  4 ++--
 arch/mips/lib/reloc.c  | 11 +++++------
 2 files changed, 7 insertions(+), 8 deletions(-)
Signature · 7 lines
2.20.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox