Skip to content

ipv6: avoid taking refcnt on dst during route lookup

Wei Wang netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 5 repliesIn review
  2. v25 patches 4 repliesSuperseded
  3. v15 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- Handled fib6_rule_lookup() when CONFIG_IPV6_MULTIPLE_TABLES is not configured in patch 03 (suggested by David Ahern)
- Removed the renaming of l3mdev_link_scope_lookup() in patch 05 (suggested by David Ahern)
- Moved definition of ip6_route_output_flags() from an inline function in /net/ipv6/route.c to net/ipv6/route.c in order to address kbuild error in patch 05

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ipv6: introduce RT6_LOOKUP_F_DST_NOREF flag in ip6_pol_route()include/net/ip6_route.h net/ipv6/route.c+31 -430 replies
2/5ipv6: initialize rt6->rt6i_uncached in all pre-allocated dst entriesnet/ipv6/route.c+3 -00 replies
3/5ipv6: honor RT6_LOOKUP_F_DST_NOREF in rule lookup logicinclude/net/ip6_route.h net/ipv6/fib6_rules.c net/ipv6/ip6_fib.c+20 -70 replies
4/5ipv6: convert rx data path to not take refcnt on dstnet/ipv6/route.c+4 -30 replies
5/5ipv6: convert major tx path to use RT6_LOOKUP_F_DST_NOREFdrivers/net/vrf.c include/net/ip6_route.h net/ipv6/route.c +1 more+37 -80 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric DumazetMahesh BandewarDavid Ahern
SeriesR-b R-b
1/5A-b A-b
2/5A-b A-b
3/5
4/5A-b A-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 net-next 0/5] ipv6: avoid taking refcnt on dst during route lookup

From: Wei Wang <[email protected]>

Ipv6 route lookup code always grabs refcnt on the dst for the caller. But for certain cases, grabbing refcnt is not always necessary if the call path is rcu protected and the caller does not cache the dst. Another issue in the route lookup logic is:
When there are multiple custom rules, we have to do the lookup into each table associated to each rule individually. And when we can't find the route in one table, we grab and release refcnt on net->ipv6.ip6_null_entry before going to the next table. This operation is completely redundant, and causes false issue because net->ipv6.ip6_null_entry is a shared object.

This patch set introduces a new flag RT6_LOOKUP_F_DST_NOREF for route lookup callers to set, to avoid any manipulation on the dst refcnt. And it converts the major input and output path to use it.

The performance gain is noticable.
I ran synflood tests between 2 hosts under the same switch. Both hosts have 20G mlx NIC, and 8 tx/rx queues.
Sender sends pure SYN flood with random src IPs and ports using trafgen. Receiver has a simple TCP listener on the target port.
Both hosts have multiple custom rules:
- For incoming packets, only local table is traversed.
- For outgoing packets, 3 tables are traversed to find the route. The packet processing rate on the receiver is as follows:
- Before the fix: 3.78Mpps
- After the fix: 5.50Mpps

v2->v3:
- Handled fib6_rule_lookup() when CONFIG_IPV6_MULTIPLE_TABLES is not configured in patch 03 (suggested by David Ahern)
- Removed the renaming of l3mdev_link_scope_lookup() in patch 05 (suggested by David Ahern)
- Moved definition of ip6_route_output_flags() from an inline function in /net/ipv6/route.c to net/ipv6/route.c in order to address kbuild error in patch 05

v1->v2:
- Added a helper ip6_rt_put_flags() in patch 3 suggested by David Miller

Wei Wang (5):
ipv6: introduce RT6_LOOKUP_F_DST_NOREF flag in ip6_pol_route()
ipv6: initialize rt6->rt6i_uncached in all pre-allocated dst entries
ipv6: honor RT6_LOOKUP_F_DST_NOREF in rule lookup logic
ipv6: convert rx data path to not take refcnt on dst
ipv6: convert major tx path to use RT6_LOOKUP_F_DST_NOREF

 drivers/net/vrf.c       |   5 +-
 include/net/ip6_route.h |  15 ++++++
 net/ipv6/fib6_rules.c   |  12 +++--
 net/ipv6/ip6_fib.c      |   5 +-
 net/ipv6/route.c        | 112 +++++++++++++++++++++++-----------------
 net/l3mdev/l3mdev.c     |   7 ++-
 6 files changed, 95 insertions(+), 61 deletions(-)
Signature · 1 line
2.22.0.410.gd8fdbe21b5-goog