Skip to content

use skb->protocol as l3 protocol dependency

Florian Westphal netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3netlink_delinerize: remove network header dep for reject statement also in bridge familysrc/netlink_delinearize.c tests/py/bridge/ether.t.json.output tests/py/bridge/reject.t +1 more+50 -2001 reply
2/3src: statement: disable reject statement type omission for bridgeinclude/statement.h src/json.c src/netlink_delinearize.c +1 more+16 -51 reply
3/3src: prefer meta protocol as bridge l3 dependencysrc/meta.c src/payload.c tests/py/bridge/ether.t +6 more+151 -1211 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPablo Neira Ayuso
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH nft 0/3] use skb->protocol as l3 protocol dependency

Real patch is the last one, first two do preparation work:
1. Allow removal of the dependency for the reject statement
2. Keep exact icmp type for bridge when printing.
This is needed so we do not lose the l3 protocol information. In the ip family, "reject" and "reject with icmp type port-unreachable" are the same, but in case of bridge the latter adds a protocol dependency on ipv4, whereas the former rejects ip with icmp and ipv6 with a similar icmp-v6 error packet.
3. Prefer meta protocol for bridge family for all implicit depencencies.

 include/statement.h                   |    3 
 src/json.c                            |    6 -
 src/meta.c                            |    6 -
 src/netlink_delinearize.c             |   10 +
 src/payload.c                         |   18 +++
 src/statement.c                       |    6 -
 tests/py/bridge/ether.t               |    4 
 tests/py/bridge/ether.t.json.output   |   48 ---------
 tests/py/bridge/ether.t.payload       |   24 +++-
 tests/py/bridge/icmpX.t.payload       |    4 
 tests/py/bridge/reject.t              |   28 ++---
 tests/py/bridge/reject.t.json.output  |  170 +++++---------------------------
 tests/py/bridge/reject.t.payload      |   24 ++--
 tests/py/inet/ip_tcp.t.payload.bridge |    8 -
 tests/py/inet/sets.t.payload.bridge   |    4 
 tests/py/ip/ip.t.payload.bridge       |  180 +++++++++++++++++-----------------
 16 files changed, 217 insertions(+), 326 deletions(-)