Skip to content

RFC opencapi: enable card reset and link retraining

Frederic Barrat linuxppc-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest11 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11powerpc/powernv/ioda: Fix ref count for devices with their own PEarch/powerpc/platforms/powernv/pci-ioda.c+1 -100 replies
2/11powerpc/powernv/ioda: Protect PE listarch/powerpc/platforms/powernv/pci-ioda.c+5 -11 reply
3/11powerpc/powernv/ioda: set up PE on opencapi device when enablingarch/powerpc/platforms/powernv/pci-ioda.c+23 -80 replies
4/11powerpc/powernv/ioda: Release opencapi devicearch/powerpc/platforms/powernv/pci-ioda.c+38 -200 replies
5/11powerpc/powernv/ioda: Find opencapi slot for a device nodearch/powerpc/include/asm/pnv-pci.h arch/powerpc/platforms/powernv/pci.c+8 -30 replies
6/11pci/hotplug/pnv-php: Remove erroneous warningdrivers/pci/hotplug/pnv_php.c+0 -60 replies
7/11pci/hotplug/pnv-php: Improve error msg on power state change failuredrivers/pci/hotplug/pnv_php.c+11 -50 replies
8/11pci/hotplug/pnv-php: Register opencapi slotsdrivers/pci/hotplug/pnv_php.c+4 -10 replies
9/11pci/hotplug/pnv-php: Relax check when disabling slotdrivers/pci/hotplug/pnv_php.c+7 -11 reply
10/11pci/hotplug/pnv-php: Wrap warnings in macrodrivers/pci/hotplug/pnv_php.c+18 -150 replies
11/11ocxl: Add PCI hotplug dependency to Kconfigdrivers/misc/ocxl/Kconfig+1 -01 reply

Reviews trailers per patch

3 of 11 patches have a Reviewed-by or Acked-by.

PatchAndrew Donnellan
1/11
2/11R-b
3/11
4/11
5/11
6/11
7/11
8/11
9/11R-b
10/11
11/11A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 00/11] opencapi: enable card reset and link retraining

This is the linux part of the work to use the PCI hotplug framework to control an opencapi card so that it can be reset and re-read after flashing a new FPGA image.

It needs support in skiboot:
http://patchwork.ozlabs.org/project/skiboot/list/?series=114803
On an old skiboot, it will do nothing.

A virtual PCI slot is created for the opencapi adapter, and its state can be controlled through the pnv-php hotplug driver:

echo 0|1 > /sys/bus/pci/slots/OPENCAPI-<...>/power

Note that the power to the card is not really turned off, as the card needs to stay on to be flashed with a new image. Instead the card is placed in reset.

The first part of the series mostly deals with the pci/ioda state, as the devices can now go away and the state needs to be cleaned up.

The second part is modifications to the hotplug driver on powernv, so that a virtual slot is created for the opencapi adapters found in the device tree

Frederic Barrat (11):
powerpc/powernv/ioda: Fix ref count for devices with their own PE powerpc/powernv/ioda: Protect PE list powerpc/powernv/ioda: set up PE on opencapi device when enabling powerpc/powernv/ioda: Release opencapi device powerpc/powernv/ioda: Find opencapi slot for a device node pci/hotplug/pnv-php: Remove erroneous warning pci/hotplug/pnv-php: Improve error msg on power state change failure pci/hotplug/pnv-php: Register opencapi slots pci/hotplug/pnv-php: Relax check when disabling slot pci/hotplug/pnv-php: Wrap warnings in macro
ocxl: Add PCI hotplug dependency to Kconfig

 arch/powerpc/include/asm/pnv-pci.h        |   1 +
 arch/powerpc/platforms/powernv/pci-ioda.c | 106 ++++++++++++++--------
 arch/powerpc/platforms/powernv/pci.c      |  10 +-
 drivers/misc/ocxl/Kconfig                 |   1 +
 drivers/pci/hotplug/pnv_php.c             |  66 ++++++++------
 5 files changed, 115 insertions(+), 69 deletions(-)
Signature · 1 line
2.21.0