Skip to content

fixes and improvements for rawdev

Bruce Richardson dpdk-dev 3 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyApplied
  2. v24 patches 4 repliesSuperseded
  3. v12 patches 0 repliesSuperseded

Changes in v3 from the cover letter

* dropped patch 1 which has been independently fixed
* added autotest to the drivers set rather than fast tests one

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3app/test: add missing rawdev autotest to meson buildapp/test/meson.build+3 -00 replies
2/3raw/skeleton: remove compile-time constant for device iddrivers/raw/skeleton_rawdev/skeleton_rawdev_test.c+28 -270 replies
3/3rawdev: pass the device id as parameter to selftestdrivers/raw/skeleton_rawdev/skeleton_rawdev.c drivers/raw/skeleton_rawdev/skeleton_rawdev.h drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c +2 more+10 -70 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchHemant Agrawal
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [dpdk-dev] [PATCH v3 0/3] fixes and improvements for rawdev

This set includes some general fixes and improvements for rawdev, the rawdev autotests and the rawdev skeleton example implementation. Specifically:

* the unit test were failing for me due to bad memory management
* the unit tests were not present in the meson builds due to missing file in file list
* the self-test function for a rawdev driver did not take the actual device id as a parameter:
- because of this the skeleton driver always assumed device 0 was to be tested, an unsafe assumption

V3:
* dropped patch 1 which has been independently fixed
* added autotest to the drivers set rather than fast tests one

V2:
extended the set with additional fixes to allow selftests to know what instance the tests are to be run on.

*** SUBJECT HERE ***

*** BLURB HERE ***

Bruce Richardson (3):
app/test: add missing rawdev autotest to meson build raw/skeleton: remove compile-time constant for device id
rawdev: pass the device id as parameter to selftest

 app/test/meson.build                          |  3 +
 drivers/raw/skeleton_rawdev/skeleton_rawdev.c |  8 ++-
 drivers/raw/skeleton_rawdev/skeleton_rawdev.h |  2 +-
 .../skeleton_rawdev/skeleton_rawdev_test.c    | 58 ++++++++++---------
 lib/librte_rawdev/rte_rawdev.c                |  2 +-
 lib/librte_rawdev/rte_rawdev_pmd.h            |  2 +-
 6 files changed, 41 insertions(+), 34 deletions(-)
Signature · 1 line
2.21.0