Skip to content

Static checker fixes and NVMe 1.4 support

Bart Van Assche linux-nvme 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13Remove superfluous castsfabrics.c nvme-print.c plugins/intel/intel-nvme.c +2 more+80 -802 replies
1/13Remove superfluous castsnvme.h+25 -132 replies
1/13Remove superfluous casts+0 -00 replies
2/13Use NULL instead of 0 where a pointer is expectedplugins/seagate/seagate-nvme.c plugins/virtium/virtium-nvme.c+8 -80 replies
3/13huawei: Declare local functions staticplugins/huawei/huawei-nvme.c+2 -10 replies
4/13seagate: Declare local functions staticnvme-models.c plugins/seagate/seagate-nvme.c+14 -110 replies
5/13virtium: Declare local symbols staticplugins/virtium/virtium-nvme.c+3 -10 replies
6/13lightnvm: Fix an endianness issuenvme-lightnvm.c+1 -10 replies
7/13virtium: Fix an endianness issueplugins/virtium/virtium-nvme.c+1 -10 replies
8/13wdc: Fix endianness bugsplugins/wdc/wdc-nvme.c+8 -40 replies
9/13Avoid using arrays with a variable lengthnvme-print.c+3 -10 replies
10/13nvme-cli: Rework the code for getting and setting NVMf propertiesnvme-ioctl.c nvme-ioctl.h+63 -600 replies
11/13nvme-cli: Skip properties that are not supportednvme-ioctl.c+4 -10 replies
12/13Introduce NVMe 1.4 Identify Namespace fields in struct nvme_id_nslinux/nvme.h+6 -10 replies
13/13nvme-cli: Report the NVMe 1.4 NPWG, NPWA, NPDG, NPDA and NOWS fieldsnvme-print.c+7 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH nvme-cli 00/13] Static checker fixes and NVMe 1.4 support

Hi Keith,

This patch series is what I came up with after having analyzed the output of 'sparse' for the nvme-cli source code. This patch series also includes two patches that add support for the new NVMe 1.4 Identify Namespace fields.

Thanks,

Bart.

Bart Van Assche (13):
Remove superfluous casts
Use NULL instead of 0 where a pointer is expected
huawei: Declare local functions static
seagate: Declare local functions static
virtium: Declare local symbols static
lightnvm: Fix an endianness issue
virtium: Fix an endianness issue
wdc: Fix endianness bugs
Avoid using arrays with a variable length
nvme-cli: Rework the code for getting and setting NVMf properties
nvme-cli: Skip properties that are not supported Introduce NVMe 1.4 Identify Namespace fields in struct nvme_id_ns
nvme-cli: Report the NVMe 1.4 NPWG, NPWA, NPDG, NPDA and NOWS fields

 fabrics.c                      |   2 +-
 linux/nvme.h                   |   7 +-
 nvme-ioctl.c                   | 126 +++++++++++++++++----------------
 nvme-ioctl.h                   |   2 +-
 nvme-lightnvm.c                |   2 +-
 nvme-models.c                  |   1 +
 nvme-print.c                   |  51 +++++++------
 plugins/huawei/huawei-nvme.c   |   3 +-
 plugins/intel/intel-nvme.c     |  16 ++---
 plugins/seagate/seagate-nvme.c |  58 +++++++--------
 plugins/virtium/virtium-nvme.c |  14 ++--
 plugins/wdc/wdc-nvme.c         |  88 ++++++++++++-----------
 12 files changed, 200 insertions(+), 170 deletions(-)
Signature · 1 line
2.22.0.rc3