Skip to content

net: fddi: skfp: Use PCI generic definitions instead of private duplicates

Puranjay Mohan linux-kernel-mentees linux-pci lkml netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 1 replyIn review
  2. v43 patches 1 replySuperseded
  3. v33 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v23 patches4 repliesSuperseded

Changes in v5 from the cover letter

Removed unused PCI definitions which were left in v4

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net: fddi: skfp: Rename local PCI defines to match generic PCI definesdrivers/net/fddi/skfp/drvfbi.c drivers/net/fddi/skfp/h/skfbi.h+3 -30 replies
2/3net: fddi: skfp: Include generic PCI definitionsdrivers/net/fddi/skfp/drvfbi.c+1 -00 replies
3/3net: fddi: skfp: Remove unused private PCI definitionsdrivers/net/fddi/skfp/h/skfbi.h+1 -2240 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates

This patch series removes the private duplicates of PCI definitions in favour of generic definitions defined in pci_regs.h.

This driver only uses some of the generic PCI definitons, which are included from pci_regs.h and thier private versions are removed from skfbi.h with all other private defines.

The skfbi.h defines PCI_REV_ID and other private defines with different names, these are renamed to Generic PCI names to make them compatible with defines in pci_regs.h.

All unused defines are removed from skfbi.h.

Changes in v5:
Removed unused PCI definitions which were left in v4

Changes in v4:
Removed unused PCI definitions which were left in v3

Changes in v3:
Renamed all local PCI definitions to Generic names. Corrected coding style mistakes.

Changes in v2:
Converted individual patches to a series.
Made sure that individual patches build correctly

Puranjay Mohan (3):
net: fddi: skfp: Rename local PCI defines to match generic PCI defines
net: fddi: skfp: Include generic PCI definitions
net: fddi: skfp: Remove unused private PCI definitions

 drivers/net/fddi/skfp/drvfbi.c  |   3 +-
 drivers/net/fddi/skfp/h/skfbi.h | 231 +-------------------------------
 2 files changed, 6 insertions(+), 228 deletions(-)
Signature · 1 line
2.21.0