Skip to content

x86/hpet: Cleanup the channel management

Thomas Gleixner lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest29 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/29x86/hpet: Simplify CPU online codearch/x86/kernel/hpet.c+2 -290 replies
2/29x86/hpet: Replace printk(KERN...) with pr_...()arch/x86/kernel/hpet.c+19 -260 replies
3/29x86/hpet: Restructure init codearch/x86/kernel/hpet.c+43 -380 replies
4/29x86/hpet: Remove pointless x86-64 specific #includearch/x86/kernel/hpet.c+0 -40 replies
5/29x86/hpet: Remove unused parameter from hpet_next_event()arch/x86/kernel/hpet.c+5 -50 replies
6/29x86/hpet: Remove the unused hpet_msi_read() functionarch/x86/include/asm/hpet.h arch/x86/kernel/hpet.c+0 -80 replies
7/29x86/hpet: Mark init functions __initarch/x86/kernel/hpet.c+3 -30 replies
8/29x86/hpet: Sanitize stub functionsarch/x86/kernel/hpet.c+3 -90 replies
9/29x86/hpet: Move static and global variables to one placearch/x86/kernel/hpet.c+22 -280 replies
10/29x86/hpet: Shuffle code around for readability sakearch/x86/kernel/hpet.c+41 -400 replies
11/29x86/hpet: Separate counter check out of clocksource register codearch/x86/kernel/hpet.c+31 -340 replies
12/29x86/hpet: Simplify counter validationarch/x86/kernel/hpet.c+4 -60 replies
13/29x86/hpet: Decapitalize and rename EVT_TO_HPET_DEVarch/x86/kernel/hpet.c+10 -170 replies
14/29x86/hpet: Remove not required includesarch/x86/kernel/hpet.c+1 -110 replies
15/29x86/hpet: Make naming consistentarch/x86/kernel/hpet.c+10 -100 replies
16/29x86/hpet: Clean up commentsarch/x86/kernel/hpet.c+23 -180 replies
17/29x86/hpet: Coding style cleanuparch/x86/kernel/hpet.c+26 -170 replies
18/29x86/hpet: Introduce struct hpet_base and struct hpet_channelarch/x86/kernel/hpet.c+49 -350 replies
19/29x86/hpet: Use cached channel dataarch/x86/kernel/hpet.c+16 -250 replies
20/29x86/hpet: Add mode information to struct hpet_channelarch/x86/kernel/hpet.c+11 -00 replies
21/29x86/hpet: Add function to select a /dev/hpet channelarch/x86/kernel/hpet.c+17 -00 replies
22/29x86/hpet: Rename variables to prepare for switching to channelsarch/x86/kernel/hpet.c+62 -620 replies
23/29x86/hpet: Move clockevents into channelsarch/x86/include/asm/hpet.h arch/x86/kernel/apic/msi.c arch/x86/kernel/hpet.c+64 -850 replies
24/29x86/hpet: Use cached info instead of extra flagsarch/x86/kernel/hpet.c+23 -531 reply
25/29x86/hpet: Wrap legacy clockevent in hpet_channelarch/x86/kernel/hpet.c+27 -220 replies
26/29x86/hpet: Consolidate clockevent functionsarch/x86/kernel/hpet.c+25 -674 replies
27/29x86/hpet: Carve out shareable parts of init_one_hpet_msi_clockevent()arch/x86/kernel/hpet.c+20 -140 replies
28/29x86/hpet: Use common init for legacy clockeventarch/x86/kernel/hpet.c+54 -331 reply
29/29x86/hpet: Use channel for legacy clockevent storagearch/x86/kernel/hpet.c+3 -80 replies

Reviews trailers per patch

3 of 29 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchIngo Molnar
SeriesR-b
1/29
2/29
3/29
4/29
5/29
6/29
7/29
8/29
9/29
10/29
11/29
12/29
13/29
14/29
15/29
16/29
17/29
18/29
19/29
20/29
21/29
22/29
23/29
24/29R-b
25/29
26/29R-b
27/29
28/29R-b
29/29

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [patch 00/29] x86/hpet: Cleanup the channel management

When reviewing the HPET NMI watchdog series, I stared into the HPET code and the proposed changes. The latter try to add yet another layer of duct tape and ifdeffery to the existing maze. No, thanks.

The following series cleans up the channel management and consolidates all state storage into a single place instead of 3 different ad hoc allocated places which carry redundant information and make the code hard to follow.

The reservation of a HPET channel for a NMI watchdog becomes a few lines of code after that series and just fits naturaly into that scheme without glue and more extra storage and ifdeffery.

For your conveniance the series is also available from git:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.x86/hpet

Thanks,

tglx

8<---------------------

 include/asm/hpet.h |    7 
 kernel/apic/msi.c  |    4 
 kernel/hpet.c      |  937 +++++++++++++++++++++++------------------------------
 3 files changed, 428 insertions(+), 520 deletions(-)