x86/hpet: Cleanup the channel management
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest29 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/29 | x86/hpet: Simplify CPU online codearch/ | +2 | 0 replies | |
| 2/29 | x86/hpet: Replace printk(KERN...) with pr_...()arch/ | +19 | 0 replies | |
| 3/29 | x86/hpet: Restructure init codearch/ | +43 | 0 replies | |
| 4/29 | x86/hpet: Remove pointless x86-64 specific #includearch/ | +0 | 0 replies | |
| 5/29 | x86/hpet: Remove unused parameter from hpet_next_event()arch/ | +5 | 0 replies | |
| 6/29 | x86/hpet: Remove the unused hpet_msi_read() functionarch/ arch/ | +0 | 0 replies | |
| 7/29 | x86/hpet: Mark init functions __initarch/ | +3 | 0 replies | |
| 8/29 | x86/hpet: Sanitize stub functionsarch/ | +3 | 0 replies | |
| 9/29 | x86/hpet: Move static and global variables to one placearch/ | +22 | 0 replies | |
| 10/29 | x86/hpet: Shuffle code around for readability sakearch/ | +41 | 0 replies | |
| 11/29 | x86/hpet: Separate counter check out of clocksource register codearch/ | +31 | 0 replies | |
| 12/29 | x86/hpet: Simplify counter validationarch/ | +4 | 0 replies | |
| 13/29 | x86/hpet: Decapitalize and rename EVT_TO_HPET_DEVarch/ | +10 | 0 replies | |
| 14/29 | x86/hpet: Remove not required includesarch/ | +1 | 0 replies | |
| 15/29 | x86/hpet: Make naming consistentarch/ | +10 | 0 replies | |
| 16/29 | x86/hpet: Clean up commentsarch/ | +23 | 0 replies | |
| 17/29 | x86/hpet: Coding style cleanuparch/ | +26 | 0 replies | |
| 18/29 | x86/hpet: Introduce struct hpet_base and struct hpet_channelarch/ | +49 | 0 replies | |
| 19/29 | x86/hpet: Use cached channel dataarch/ | +16 | 0 replies | |
| 20/29 | x86/hpet: Add mode information to struct hpet_channelarch/ | +11 | 0 replies | |
| 21/29 | x86/hpet: Add function to select a /dev/hpet channelarch/ | +17 | 0 replies | |
| 22/29 | x86/hpet: Rename variables to prepare for switching to channelsarch/ | +62 | 0 replies | |
| 23/29 | x86/hpet: Move clockevents into channelsarch/ arch/ arch/ | +64 | 0 replies | |
| 24/29 | x86/hpet: Use cached info instead of extra flagsarch/ | +23 | 1 reply | |
| 25/29 | x86/hpet: Wrap legacy clockevent in hpet_channelarch/ | +27 | 0 replies | |
| 26/29 | x86/hpet: Consolidate clockevent functionsarch/ | +25 | 4 replies | |
| 27/29 | x86/hpet: Carve out shareable parts of init_one_hpet_msi_clockevent()arch/ | +20 | 0 replies | |
| 28/29 | x86/hpet: Use common init for legacy clockeventarch/ | +54 | 1 reply | |
| 29/29 | x86/hpet: Use channel for legacy clockevent storagearch/ | +3 | 0 replies |
Reviews trailers per patch
3 of 29 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Ingo Molnar |
|---|---|
| Series | R-b |
| 1/29 | |
| 2/29 | |
| 3/29 | |
| 4/29 | |
| 5/29 | |
| 6/29 | |
| 7/29 | |
| 8/29 | |
| 9/29 | |
| 10/29 | |
| 11/29 | |
| 12/29 | |
| 13/29 | |
| 14/29 | |
| 15/29 | |
| 16/29 | |
| 17/29 | |
| 18/29 | |
| 19/29 | |
| 20/29 | |
| 21/29 | |
| 22/29 | |
| 23/29 | |
| 24/29 | R-b |
| 25/29 | |
| 26/29 | R-b |
| 27/29 | |
| 28/29 | R-b |
| 29/29 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [patch 00/29] x86/hpet: Cleanup the channel management
When reviewing the HPET NMI watchdog series, I stared into the HPET code and the proposed changes. The latter try to add yet another layer of duct tape and ifdeffery to the existing maze. No, thanks.
The following series cleans up the channel management and consolidates all state storage into a single place instead of 3 different ad hoc allocated places which carry redundant information and make the code hard to follow.
The reservation of a HPET channel for a NMI watchdog becomes a few lines of code after that series and just fits naturaly into that scheme without glue and more extra storage and ifdeffery.
For your conveniance the series is also available from git:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.x86/hpet
Thanks,
tglx
8<---------------------
include/asm/hpet.h | 7 kernel/apic/msi.c | 4 kernel/hpet.c | 937 +++++++++++++++++++++++------------------------------ 3 files changed, 428 insertions(+), 520 deletions(-)