Skip to content

cleanup cppcheck signed shifting errors

Phong Tran bpf linux-omap linux-samsung-soc lkml netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest15 patches 3 repliesIn review
  2. v215 patches 9 repliesSuperseded
  3. v115 patches 7 repliesApplied

Changes in v3 from the cover letter

* Update the comments from Russell King.
* Update commit message and cover letter for clearly the reason as request Peter Zijlstra
* For avoiding the broken only change (1<<nr) pattern to BIT(nr)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15arm: perf: cleanup cppcheck shifting errorarch/arm/kernel/perf_event_v7.c+3 -31 reply
2/15ARM: davinci: cleanup cppcheck shifting errorsarch/arm/mach-davinci/ddr2.h+3 -30 replies
3/15ARM: ep93xx: cleanup cppcheck shifting errorsarch/arm/mach-ep93xx/soc.h+67 -670 replies
4/15ARM: exynos: cleanup cppcheck shifting errorarch/arm/mach-exynos/suspend.c+1 -11 reply
5/15ARM: footbridge: cleanup cppcheck shifting errorarch/arm/mach-footbridge/dc21285.c+1 -10 replies
6/15ARM: imx: cleanup cppcheck shifting errorsarch/arm/mach-imx/iomux-mx3.h+32 -320 replies
7/15ARM: ks8695: cleanup cppcheck shifting errorarch/arm/mach-ks8695/regs-pci.h+2 -20 replies
8/15ARM: mmp: cleanup cppcheck shifting errorsarch/arm/mach-mmp/pm-mmp2.h arch/arm/mach-mmp/pm-pxa910.h+57 -570 replies
9/15ARM: omap2: cleanup cppcheck shifting errorarch/arm/mach-omap2/powerdomain.c+1 -10 replies
10/15ARM: orion5x: cleanup cppcheck shifting errorsarch/arm/mach-orion5x/pci.c+4 -40 replies
11/15ARM: pxa: cleanup cppcheck shifting errorsarch/arm/mach-pxa/irq.c+2 -20 replies
12/15ARM: vexpress: cleanup cppcheck shifting errorarch/arm/mach-vexpress/spc.c+2 -21 reply
13/15ARM: mm: cleanup cppcheck shifting errorsarch/arm/mm/fault.h+3 -30 replies
14/15ARM: bpf: cleanup cppcheck shifting errorarch/arm/net/bpf_jit_32.c+1 -10 replies
15/15ARM: vfp: cleanup cppcheck shifting errorsarch/arm/vfp/vfpinstr.h+4 -40 replies

Reviews trailers per patch

4 of 15 patches have a Reviewed-by or Acked-by.

PatchH Hartley SweetenAlexander SverdlinAndrew LunnWill DeaconSudeep Holla
1/15A-b
2/15
3/15A-b A-b
4/15
5/15
6/15
7/15
8/15
9/15
10/15R-b
11/15
12/15A-b
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [PATCH V3 00/15] cleanup cppcheck signed shifting errors

This is also do as the suggestion of "Linux Kernel Mentorship Task List"

https://wiki.linuxfoundation.org/lkmp/lkmp_task_list#cleanup_cppcheck_errors
"Shifting signed 32-bit value by 31 bits is undefined behaviour errors"

Change Log:

V2: Using BIT() macro instead of (1UL << nr)

V3:
* Update the comments from Russell King.
* Update commit message and cover letter for clearly the reason as request Peter Zijlstra
* For avoiding the broken only change (1<<nr) pattern to BIT(nr)

Phong Tran (15):
arm: perf: cleanup cppcheck shifting error
ARM: davinci: cleanup cppcheck shifting errors
ARM: ep93xx: cleanup cppcheck shifting errors
ARM: exynos: cleanup cppcheck shifting error
ARM: footbridge: cleanup cppcheck shifting error
ARM: imx: cleanup cppcheck shifting errors
ARM: ks8695: cleanup cppcheck shifting error
ARM: mmp: cleanup cppcheck shifting errors
ARM: omap2: cleanup cppcheck shifting error
ARM: orion5x: cleanup cppcheck shifting errors
ARM: pxa: cleanup cppcheck shifting errors
ARM: vexpress: cleanup cppcheck shifting error
ARM: mm: cleanup cppcheck shifting errors
ARM: bpf: cleanup cppcheck shifting error
ARM: vfp: cleanup cppcheck shifting errors

 arch/arm/kernel/perf_event_v7.c    |   6 +-
 arch/arm/mach-davinci/ddr2.h       |   6 +-
 arch/arm/mach-ep93xx/soc.h         | 134 ++++++++++++++++++-------------------
 arch/arm/mach-exynos/suspend.c     |   2 +-
 arch/arm/mach-footbridge/dc21285.c |   2 +-
 arch/arm/mach-imx/iomux-mx3.h      |  64 +++++++++---------
 arch/arm/mach-ks8695/regs-pci.h    |   4 +-
 arch/arm/mach-mmp/pm-mmp2.h        |  40 +++++------
 arch/arm/mach-mmp/pm-pxa910.h      |  74 ++++++++++----------
 arch/arm/mach-omap2/powerdomain.c  |   2 +-
 arch/arm/mach-orion5x/pci.c        |   8 +--
 arch/arm/mach-pxa/irq.c            |   4 +-
 arch/arm/mach-vexpress/spc.c       |   4 +-
 arch/arm/mm/fault.h                |   6 +-
 arch/arm/net/bpf_jit_32.c          |   2 +-
 arch/arm/vfp/vfpinstr.h            |   8 +--
 16 files changed, 183 insertions(+), 183 deletions(-)
Signature · 1 line
2.11.0